Skip to content

Commit

Permalink
chore: display warning to user if running nightly version (#9683)
Browse files Browse the repository at this point in the history
* use shared compile time version builder

* add warning message on nightly builds

* display warning on nightly builds

* derive nightly build from tag name

* no need to pass IS_NIGHTLY in, derive from tag name

* update warning message

* fix rustfmt

* fix clippy

* clean up, default to always use `-dev` if not on tag

* provide way for users to mute the warning by setting a FOUNDRY_DISABLE_NIGHTLY_WARNING environment variable

* fix fmt

* add profile to version

* fix clippy

* fix fmt

* remove redundant build_timestamp as it is unused

* unify build scripts, update cheatcodes build script, fix vm.getFoundryVersion() cheatcode

* fix clippy

* build timestamp not needed anymore, move to use single build script in foundry_common and export from there

* clean up

* add timestamp due to users / documentation relying on it

* use verbose message format for cli --version, use SemVer compatible unix timestamp for cheatcode, fix nits

* make IS_NIGHTLY_VERSION conditional

* use semver for cheatcode

* fix test

* fix value

* forge fmt

* nits, update getFoundryVersion cheatcode docs

* fix incorrect version passed to forge cli, add unix timestamp to human readable --version

* add tests, add short version / long version, address feedback

* prefer build_timestamp for short version too

* fixes, add anvil tests for parsing

* add back unix timestamp in full version

* fix semver test
  • Loading branch information
zerosnacks authored Jan 21, 2025
1 parent 2ddea87 commit 62147c8
Show file tree
Hide file tree
Showing 29 changed files with 284 additions and 169 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ jobs:
attestations: write
name: ${{ matrix.target }} (${{ matrix.runner }})
runs-on: ${{ matrix.runner }}
env:
TAG_NAME: ${{ (env.IS_NIGHTLY == 'true' && 'nightly') || needs.prepare.outputs.tag_name }}
timeout-minutes: 240
needs: prepare
strategy:
Expand Down Expand Up @@ -272,7 +274,7 @@ jobs:
issue:
name: Open an issue
runs-on: ubuntu-latest
needs: [prepare, release-docker, release, cleanup]
needs: [ prepare, release-docker, release, cleanup ]
if: failure()
steps:
- uses: actions/checkout@v4
Expand Down
Loading

0 comments on commit 62147c8

Please sign in to comment.