ci(github): update CI workflow #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to correct foundry github action repo add identifier to compat checks Also, shouldn't the Via-IR compilation time checks use the latest solc?
mds1
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Thank you!
Also, shouldn't the Via-IR compilation time checks use the latest solc?
The intent of those is mainly to help prevent accidentally re-introducing regressions in build time that previously occurred when using that version. It's possible improvements to solc in future 0.8.x versions would no longer have resulted in those regressions, so I think it's more conservative to stick with the version known to be susceptible to the performance hits we saw
mds1
added a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to correct foundry github action repo
add identifier to compat checks
Also, shouldn't the Via-IR compilation time checks use the latest solc?