Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non breaking changes for cryptsetup #759

Merged
merged 5 commits into from
Aug 3, 2022

Conversation

ricardosalveti
Copy link
Member

Separating the most common and non breaking changes from #732 in order to facilitate the review and landing.

Align with 29e1e2ad0b6fd0db0e099831ba331b4ffa2b094b from oe-core, which
removes duplicated check for PARTLABEL and change to use elif instead of
a sequence of if blocks.

Signed-off-by: Ricardo Salveti <[email protected]>
@ricardosalveti
Copy link
Member Author

Done this as a way to allow us landing in steps, as I still want to extend the other pr for covering the tpm 2.0 use case.

Copy link
Contributor

@Tim-Anderson Tim-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Provide module configuration file for p11-kit, in order to allow auto
discovery by tools using p11-kit.

Signed-off-by: Ricardo Salveti <[email protected]>
We only support LUKS2 on LmP, so make sure it gets enabled by default on
both target and native builds.

Signed-off-by: Ricardo Salveti <[email protected]>
Enable support for cryptsetup by default, along with cryptsetup plugins
(which allows cryptsetup to understand the metadata stored by systemd),
openssl and pkcs11.

Signed-off-by: Ricardo Salveti <[email protected]>
LUKS2-based devices requires an additional resize (cryptsetup resize)
before performing the actual file system resize with resize2fs.

Signed-off-by: Ricardo Salveti <[email protected]>
Copy link
Contributor

@MrCry0 MrCry0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MrCry0 MrCry0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Member

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 7fd62e5 into foundriesio:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants