Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: lmp-image-common: only increase overhead factor for QEMU targets #191

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

mike-scott
Copy link
Contributor

As a part of the LmP common image changes, we run a resize-helper which
expands the rootfs to fill the available space. This usually takes care
of needing enough space on the rootfs to download a complete OTA image.
(about double the size at a minimum)

QEMU target images are not expanded past their original size during this
process and so we increased the overhead factor for all targets to 2.3.

This has 2 downsides:

  1. Subscribers have a hard time overriding this setting
  2. non-QEMU target wic images are needlessly larger than they should be
    due to the resize-helper.

By selectively setting an overridable value of 2.3 for QEMU targets,
we solve both of these issues.

Signed-off-by: Michael Scott [email protected]

As a part of the LmP common image changes, we run a resize-helper which
expands the rootfs to fill the available space.  This usually takes care
of needing enough space on the rootfs to download a complete OTA image.
(about double the size at a minimum)

QEMU target images are not expanded past their original size during this
process and so we increased the overhead factor for all targets to 2.3.

This has 2 downsides:
1. Subscribers have a hard time overriding this setting
2. non-QEMU target wic images are needlessly larger than they should be
   due to the resize-helper.

By selectively setting an overridable value of 2.3 for QEMU targets,
we solve both of these issues.

Signed-off-by: Michael Scott <[email protected]>
@mike-scott mike-scott self-assigned this Jun 25, 2020
@mike-scott mike-scott merged commit cd96172 into foundriesio:master Jun 26, 2020
@mike-scott mike-scott deleted the allow-overhead-change branch November 11, 2020 22:38
quaresmajose pushed a commit that referenced this pull request Nov 9, 2022
Relevant changes:
- de0eb14 Merge pull request #210 from YoeDistro/yoe/mut
- 1bf66f8 linux-firmware: Use nonarch_base_libdir instead of hardcoding /lib
- 478e0c4 Merge pull request #209 from YoeDistro/yoe/mut
- 7ca49de ti-18xx-wlconf: Drop spurious dot from PV
- aff7e79 ti-18xx-wlconf: Use nonarch_base_libdir instead of hardcoding /lib
- f244dd4 Merge pull request #207 from chrisdimich/master
- d52f46a linux-boundary: bump revision to bb58f0ee
- 1e88fc2 Merge pull request #206 from Ossanes/topic/fix-nitrogen8-boards
- 47d2543 nitrogen*: Drop duplicated WKS dependencies
- b806279 nitrogen8*: Drop useless overrides for WKS_FILE_DEPENDS
- 18912db Merge pull request #203 from boundarydevices/master
- 4d1b126 u-boot-boundary: fix fw_env.config management
- bd3eb22 u-boot-boundary: switch filesextrapaths to generic-bsp
- 7596527 Merge pull request #202 from YoeDistro/yoe/mut
- 1efcb1b recipes: Use SPDX naming scheme for LICENSE field
- a27ac73 Merge pull request #199 from chrisdimich/master
- b30a5bc u-boot-boundary: bump revision to 3d5e7f60
- 4d7c7c5 linux-boundary: bump revision to 04f4286f
- f467829 Merge pull request #198 from Ossanes/topic/linux-kontron
- 100b41b linux-kontron: defconfig: Rework to enable CONFIG_KPROBES
- d236514 linux-kontron: Upgrade 5.4.41>5.10.95
- dc91d5e Merge pull request #197 from Freescale/topic/simplify-overrides
- b034e5c Rework machine definitions to reduce duplication
- bf7ae43 u-boot-script-toradex: Revert wrong override change
- 671aee4 Generalize overrides subsystem for NXP and Mainline support
- a161b3a Merge pull request #196 from Ossanes/topic/nitrogen8mp
- 52e9a93 nitrogen8mp: Define nxp as default BSP
- 10a470a Merge pull request #195 from YoeDistro/yoe/mut
- 4560e22 layers: Bump to use kirkstone
- 0c68a5a Merge pull request #193 from Ossanes/topic/imx7d-remarkable2-remove-firmwares
- 654d5b5 imx7d-remarkable2: Remove bcm43456 firmware as it has no providers
- f8d9213 Merge pull request #192 from Ossanes/topic/imx6dl-riotboard-uboot
- e78de66 imx6dl-riotboard: Fix u-boot target
- 6059586 Merge pull request #191 from sapiippo/apalis-imx6
- 61b70a0 apalis-imx6: add missing space to append
- b3670f9 Merge pull request #190 from MaxKrummenacher/master
- e064d0e colibri-imx6ull: fix mistyped override
- b26df7f Merge pull request #187 from boundarydevices/master
- 748b8f0 linux-boundary: bump revision to acef1311
- f007a9f Merge pull request #185 from MaxKrummenacher/update-toradex
- 13bd2ac machines: toradex: update
- 02bff68 linux-toradex: vf: update to 4.4.291
- 74fc138 linux-toradex: imx: update to 5.4-2.3.x-imx
- a2c343e u-boot-script-toradex: improve script
- 6e8f05b u-boot-toradex: updated to latest
- 839df32 u-boot-toradex: drop inc file
- 4661bdc Merge pull request #184 from texierp/topic/git-fetcher
- be54937 recipes: use https protocol and add explicit branch parameter
- be3442a Merge pull request #183 from Ossanes/topic/remove-dms-ba16
- f6c6d9e Merge pull request #182 from Ossanes/topic/remove-congatec
- 5dc9275 imx6q-dms-ba16: Remove files because it is not being maintained
- 00acf49 congatec: Remove defconfig
- af1c0cb Merge pull request #181 from Ossanes/topic/remove-congatec
- 3777793 congatec: Remove files because it is not being maintained
- 557e7b6 Merge pull request #180 from Ossanes/topic/u-boot-script-gateworks-imx
- d57becc u-boot-script-gateworks-imx.bb: Fix license checksum
- ea36713 Merge pull request #178 from Ossanes/topic/linux-remarkable
- 322f7f9 linux-remarkable2_5.4.bb: Fix git revision
- 5ed5d23 Merge pull request #177 from Ossanes/topic/imx6sl-warp-uboot
- 18f54fa imx6sl-warp: Fix u-boot suffix
- c57b5f3 Merge pull request #176 from Ossanes/topic/riotboard-suffix
- a9fce64 imx6dl-riotboard: Fix u-boot suffix

Signed-off-by: Ricardo Salveti <[email protected]>
quaresmajose pushed a commit that referenced this pull request Jan 10, 2023
Bumping pflag to version v1.0.5-4-gd5e0c06, which comprises the following commits:

    d5e0c06 allow for blank ip addresses (#316)
    85dd5c8 Add IPNetSlice and unit tests (#170)
    6971c29 remove dead code for checking error nil (#282)
    81378bb Add exported functions to preserve `pkg/flag` compatibility (#220)
    14457a6 Remove require pflag v1.0.3
    e8f2996 Fix typo in go.mod
    8e39cc4 gofmt
    68f4136 Add SliceValue Comments
    b22fc70 Expand SliceValue support to all slice and array types.
    c6c0f0f Add first SliceValue implementations
    9722382 Added String-To-Int64 option parsing (#211)
    4890c25 Fix package doc
    b3e76d4 Fix descriptions for StringSlice functions
    24fa697 fix misspell (#197)
    916c5bf Fix typo in count.go (#196)
    aea12ed add int32 & int64 slice support (#194)
    454a7fb add float32 & float64 slice support (#192)
    082b515 Travis: test on 1.9 as well (#191)
    252d3ee travis: update to 1.10 and 1.11 in travis tests (#190)
    0873577 Fix golint import path (#189)
    b5e1a80 Sentence restructure and grammar fix (#188)
    298182f Fix panic when parsing unknown flag followed by empty argument (#173)
    d929dcb Handle single string=>string flags without quotes (#179)
    947b89b Add map valued (string->string, string->int) flags. (#133)
    9a97c10 bytes: add support for base64 encoded flags (#177)
    3ebe029 Allow bubbling up of -test.* flags (#169)
    583c0c0 Typo correction in flag.go (#164)
    329ebf1 Allow Users To Show Deprecated Flags (#163)
    1ce0cc6 make x.Parsed() return true after AddGoFlagSet(x) and pflag.Parse() (#162)
    1cd4a0c add ability to ignore unknown flags (#160)
    ad68c28 Add multiline wrapping support (#155)
    45e82a3 Implement BytesHex type of argument (#115)
    ee5fd03 doc: clarify difference between string slice vs. array (#158)
    6a877eb DurationSlice: implementation and tests (#122)
    4c012f6 Add uintSlice and boolSlice to name prettifier (#150)
    97afa5e Prevent printing when using ContinueOnError (#144)
    1f33b80 add int16 flag (#143)
    a9789e8 Remove redundant break
    2c300e7 Fixing Count flag usage string (#141)
    be7121d Fix SetNormalizeFunc (#137)
    5c2d607 Generate flag error output for errors returned from the parseFunc (#138)
    7aff26d New: renamed intSlice to ints in usage
    230e229 Fixed: updated unittest
    adc6ccc New: added a default name to avoid stringSlice in the usage message.
    e57e3ee Delete example, what isn't even shown in docs
    80fe0fb Testing for Shorthand Lookup
    75859d1 Add example to FlagSet.ShorthandLookup
    86425cb Add example to ShorthandLookup
    10b28b3 Add note about panic in ShorthandLookup
    a84f757 Allow lookup by shorthand (#106)
    c990990 Add Go 1.8.1 to .travis.yml
    af3f947 Update .travis.yml
    f1d95a3 Unify error message for panic and f.out
    314c91c Use comparison a string with "" instead of comparison of len
    1cd6182 Prevent parsing if there are no arguments
    9c8891d Add more verbosity to panic of shorthand redefinition
    1d9fab4 Use f.out in output flag deprecation
    4995a3e Make more detailed error in Set
    9421342 Add comments for better understanding of parsing short flags
    159e1d7 Document Count function
    e466d44 Delete setFlag
    686edd7 Fix alreadythere variable name
    af10531 Note about SortFlags in README
    e453343 flag_test: fix go vet (#123)
    0328f15 Cache sorted flags
    9a906f1 Prevent changing order of flags after SetNormalizeFunc() (#121)
    d16db1e Modified to display a string default value as double quoted and escaped (#118)
    d90f37a Add SortFlags option (#113)
    b205ad1 Change `ogier` to `spf13` in docs and README
    9ff6c69 Add FlagSet.FlagUsagesWrapped(cols) which wraps to the given column (#105)
    3f939ad Removed unused field "exitOnError".

Signed-off-by: Bruce Ashfield <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants