Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fioconfig daemon #159

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Add fioconfig daemon #159

merged 2 commits into from
Apr 9, 2020

Conversation

doanac
Copy link
Member

@doanac doanac commented Apr 2, 2020

Signed-off-by: Andy Doan [email protected]

@@ -1,5 +1,6 @@
# FoundriesFactory related packages
CORE_IMAGE_BASE_INSTALL += " \
docker-cli-config \
fioconfig \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind breaking this change in a separated patch?

[Unit]
Description=Foundries.io configuration management script to extract secrets at boot
After=var.mount
ConditionPathExists=|/var/sota/config.encrypted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: don't need to set =| when you only got one condition (can be =/var...)

[Unit]
Description=Foundries.io configuration management daemon
After=network.target
ConditionPathExists=|/var/sota/sota.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: don't need to set =| when you only got one condition (can be =/var...)

ConditionPathExists=|/var/sota/sota.toml

[Service]
RestartSec=180
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably set a smaller value here, as in reality this is a critical service.

}

# We need aktualizr because we uses its device gateway connectivity and keys
DEPENDS = "aktualizr"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a run depends (RDEPENDS), right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm- something didn't work on my update to that. i need to make another change to fix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed now.

Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

@doanac
Copy link
Member Author

doanac commented Apr 3, 2020

@rsalveti - good catches. This should be a little better now.

@doanac doanac force-pushed the fioconfig branch 2 times, most recently from b79cc8d to a1df343 Compare April 9, 2020 01:52
Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ricardosalveti ricardosalveti merged commit 097385f into foundriesio:master Apr 9, 2020
doanac added a commit to doanac/meta-lmp that referenced this pull request Apr 15, 2022
Add support for multiple docker-compose files
quaresmajose pushed a commit that referenced this pull request Nov 9, 2022
Relevant changes:
- bcfa079 Merge pull request #167 from chrisdimich/hardknott
- 1d0c237 nitrogen8mp: add device trees
- b7840d2 linux-boundary: bump revision
- 7ca4269 Merge pull request #164 from chrisdimich/hardknott
- 0d4f8c0 nitrogen8mp: update DDR binaries
- af3457a Merge pull request #162 from chrisdimich/hardknott
- a65ed1a nitrogen8mp: define variables needed for imx-boot recipe
- bbc9522 Merge pull request #159 from Freescale/backport-157-to-hardknott
- e77fd19 imx7d-pico: Set UBOOT_SUFFIX to img
- d81507f imx7s-warp: Set UBOOT_SUFFIX to imx

Signed-off-by: Ricardo Salveti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants