-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fioconfig daemon #159
Add fioconfig daemon #159
Conversation
@@ -1,5 +1,6 @@ | |||
# FoundriesFactory related packages | |||
CORE_IMAGE_BASE_INSTALL += " \ | |||
docker-cli-config \ | |||
fioconfig \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind breaking this change in a separated patch?
[Unit] | ||
Description=Foundries.io configuration management script to extract secrets at boot | ||
After=var.mount | ||
ConditionPathExists=|/var/sota/config.encrypted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: don't need to set =| when you only got one condition (can be =/var...)
[Unit] | ||
Description=Foundries.io configuration management daemon | ||
After=network.target | ||
ConditionPathExists=|/var/sota/sota.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: don't need to set =| when you only got one condition (can be =/var...)
ConditionPathExists=|/var/sota/sota.toml | ||
|
||
[Service] | ||
RestartSec=180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably set a smaller value here, as in reality this is a critical service.
} | ||
|
||
# We need aktualizr because we uses its device gateway connectivity and keys | ||
DEPENDS = "aktualizr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a run depends (RDEPENDS), right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm- something didn't work on my update to that. i need to make another change to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
@rsalveti - good catches. This should be a little better now. |
b79cc8d
to
a1df343
Compare
Signed-off-by: Andy Doan <[email protected]>
Signed-off-by: Andy Doan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Add support for multiple docker-compose files
Relevant changes: - bcfa079 Merge pull request #167 from chrisdimich/hardknott - 1d0c237 nitrogen8mp: add device trees - b7840d2 linux-boundary: bump revision - 7ca4269 Merge pull request #164 from chrisdimich/hardknott - 0d4f8c0 nitrogen8mp: update DDR binaries - af3457a Merge pull request #162 from chrisdimich/hardknott - a65ed1a nitrogen8mp: define variables needed for imx-boot recipe - bbc9522 Merge pull request #159 from Freescale/backport-157-to-hardknott - e77fd19 imx7d-pico: Set UBOOT_SUFFIX to img - d81507f imx7s-warp: Set UBOOT_SUFFIX to imx Signed-off-by: Ricardo Salveti <[email protected]>
Signed-off-by: Andy Doan [email protected]