Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: lmp-device-register: bump to 263d11e #1143

Merged
merged 1 commit into from
May 9, 2023

Conversation

ricardosalveti
Copy link
Member

Relevant changes:

  • 263d11e main: refactor lmp-device-register

This version does not depend on pkcs11-tool for pkcs11 initialization and key creation, using libp11 directly instead.

@ricardosalveti ricardosalveti requested review from a team May 8, 2023 23:58
@quaresmajose
Copy link
Member

Relevant changes:

  • 263d11e main: refactor lmp-device-register

This version does not depend on pkcs11-tool for pkcs11 initialization and key creation, using libp11 directly instead.

if not specified it will build with pkcs11-too so we should need to use:

EXTRA_OECMAKE += "-DDISABLE_PKCS11=1"

https://github.com/foundriesio/lmp-device-register/pull/41/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR60

Copy link
Member

@doanac doanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop the openssl-bin RDEPENDS?

@ricardosalveti
Copy link
Member Author

if not specified it will build with pkcs11-too so we should need to use:

It doesn't depend on pkcs11-tool (runtime dependency, which was already missing before), but it still depends on libp11 (that was the main work done by Jorge).

@ricardosalveti
Copy link
Member Author

Can we drop the openssl-bin RDEPENDS?

Nice one, we should be good to drop that.

Relevant changes:
- 263d11e main: refactor lmp-device-register

This version does not depend on pkcs11-tool for pkcs11 initialization
and key creation, using libp11 directly instead.

Signed-off-by: Ricardo Salveti <[email protected]>
@ricardosalveti ricardosalveti merged commit 2f81b31 into foundriesio:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants