Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: fioconfig: Bump version #1075

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

doanac
Copy link
Member

@doanac doanac commented Mar 17, 2023

Includes changes for:

  • Improved retry handling when cert rotation fails
  • Move from umbracle/ecies to foundries/ecies fork

Includes changes for:

 * Improved retry handling when cert rotation fails
 * Move from umbracle/ecies to foundries/ecies fork

Signed-off-by: Andy Doan <[email protected]>
@doanac
Copy link
Member Author

doanac commented Mar 17, 2023

@rsalveti - I think the systemd service definition is okay. However, its missing a StartLimitInterval=0. But since the restart interval is 10s, I don't think fioconfig can get rate-limited and disabled, right?

@mwasilew - this will need some testing.

@ricardosalveti
Copy link
Member

DefaultStartLimitIntervalSec= defaults to 10s. DefaultStartLimitBurst= defaults to 5.

In the end I think it will take more than 10s, so won't necessarily get in a failed state here.

The question that follows is how do we want fioconfig service logic to be managed in case of failures? I guess we can always restart if failed in a range, which would cover the expected failure use case, and fail hard when in a crash loop (causing the rest of the system to reboot?).

Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge so we can do a bit more testing here.

@ricardosalveti ricardosalveti merged commit d687d96 into foundriesio:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants