Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsp: optee-os-fio: enable CAAM for imx7ulpea-com #1068

Merged
merged 1 commit into from
Mar 15, 2023
Merged

bsp: optee-os-fio: enable CAAM for imx7ulpea-com #1068

merged 1 commit into from
Mar 15, 2023

Conversation

MrCry0
Copy link
Contributor

@MrCry0 MrCry0 commented Mar 15, 2023 •
edited
Loading

OP-TEE seems to support CAAM for 7ulp. Enable it to fix building error

lmp/work/imx7ulpea_ucom-lmp-linux-gnueabi/optee-os-tadevkit/3.20.0+git-r0/build/export-ta_arm32/ta/7f10a757-4139-4eae-90c9-f2b2eb118139.ta
| arm-lmp-linux-gnueabi-ld.bfd: /srv/oe/build/tmp-lmp/work/imx7ulpea_ucom-lmp-linux-gnueabi/optee-os-tadevkit/3.20.0+git-r0/build/core/kernel/huk_subkey.o: in function `huk_subkey_derive':
| /srv/oe/build/tmp-lmp/work/imx7ulpea_ucom-lmp-linux-gnueabi/optee-os-tadevkit/3.20.0+git-r0/git/core/kernel/huk_subkey.c:78: undefined reference to `tee_otp_get_hw_unique_key'
| make: *** [core/arch/arm/kernel/link.mk:69: /srv/oe/build/tmp-lmp/work/imx7ulpea_ucom-lmp-linux-gnueabi/optee-os-tadevkit/3.20.0+git-r0/build/core/all_objs.o] Error 1

@MrCry0 MrCry0 mentioned this pull request Mar 15, 2023
Closed
quaresmajose
quaresmajose approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and fixes the link error

@MrCry0 MrCry0 requested review from vanmaegima and a team March 15, 2023 11:17
@MrCry0
Copy link
Contributor Author

MrCry0 commented Mar 15, 2023

LGTM, tested locally and fixes the link error

Thanks! We may wait for @vanmaegima 's approvement, Vanessa knows more about 7ulp ;-)

@MrCry0
bsp: optee-os-fio: enable CAAM for imx7ulpea-com
c4eb95b 
OP-TEE seems to support CAAM for 7ulp. Enable it to fix building
error [1].

[1]
core/kernel/huk_subkey.o: in function `huk_subkey_derive':
core/kernel/huk_subkey.c:78: undefined reference to `tee_otp_get_hw_unique_key'

Signed-off-by: Oleksandr Suvorov <[email protected]>
@ricardosalveti
Copy link
Member

Yeah, thanks for looking at this one, we should be good as we only want to make sure we're able to build correctly for it at this moment, as we will later move to the optee imx bsp version instead (only for ulp).

ricardosalveti
ricardosalveti approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit ea0b764 into foundriesio:main Mar 15, 2023
@MrCry0 MrCry0 deleted the main-7ulpea-com branch March 27, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardosalveti ricardosalveti ricardosalveti approved these changes

@quaresmajose quaresmajose quaresmajose approved these changes

@vanmaegima vanmaegima Awaiting requested review from vanmaegima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrCry0 @ricardosalveti @quaresmajose