Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new base distros with wayland support #1028

Conversation

MaxPayne86
Copy link
Contributor

Initial sanity check with

bitbake -e weston-init | awk '/^# \$SRC_URI \[/,/^SRC_URI/'

@quaresmajose
Copy link
Member

LGTM, but I didn't understand very well the sanity check command on the PR description.

Thanks for the patch @MaxPayne86

@MaxPayne86
Copy link
Contributor Author

LGTM, but I didn't understand very well the sanity check command on the PR description.

Minor test to see if the files that are normally included in weston-init and lmp-wayland distro are applied also with this new distro. Before this command of course you need to do something like

DISTRO=lmp-base-xwayland MACHINE=<YOUR-MACHINE> . setup-environment

files I'm referring to below

SRC_URI:append:lmp-wayland = " \
    file://utilities-terminal.png \
    file://background.jpg \
    file://weston.env \
    file://weston.service.patch \
    file://tmpfiles.conf \
"

@quaresmajose
Copy link
Member

Thanks for the explanation, i got it.
Recent versions of bitbake can do the same in a more elegant way:

bitbake-getvar -r weston-init SRC_URI

Copy link
Contributor

@MrCry0 MrCry0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ricardosalveti ricardosalveti merged commit 67b0a2e into foundriesio:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants