Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf/keys/uef: update keys #463

Closed
wants to merge 1 commit into from

Conversation

quaresmajose
Copy link
Member

run the helper from lmp-tools:

lmp-tools/security/uefi/gen_uefi_certs.sh

Reference foundriesio/lmp-tools@7ea4e85#diff-c78bfbab9f5b88f1573d3df4f6d34a18446b0ea33fd8c87185810b45a92c31fcR44

run the helper from lmp-tools:
> lmp-tools/security/uefi/gen_uefi_certs.sh

Reference foundriesio/lmp-tools@7ea4e85#diff-c78bfbab9f5b88f1573d3df4f6d34a18446b0ea33fd8c87185810b45a92c31fcR44

Signed-off-by: Jose Quaresma <[email protected]>
Copy link
Contributor

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on the commit title
conf/keys/uefi

Why are you rotating the reference keys?

@quaresmajose
Copy link
Member Author

because it is a requirement from foundriesio/meta-lmp@026661d

Copy link
Contributor

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my memory, I think we don't break any user by rotating this key without previous note. So I'm ok to update it

@ricardosalveti
Copy link
Member

We don't need to update / rotate all keys, just need to add the extra ones, as covered at foundriesio/lmp-tools@7ea4e85.

While it won't cause issue in lmp directly, we do have that revert patch in factories, and I believe this will cause a major conflict there.

Even without conflicts, I would rather just update what needs to be updated instead.

@quaresmajose
Copy link
Member Author

Fixed with #465

@quaresmajose quaresmajose deleted the uefi-keys branch November 11, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants