Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmp-bsp: update meta-tegra layer #278

Merged
merged 1 commit into from
Jan 23, 2023
Merged

lmp-bsp: update meta-tegra layer #278

merged 1 commit into from
Jan 23, 2023

Conversation

MrCry0
Copy link
Contributor

@MrCry0 MrCry0 commented Jan 3, 2023 •
edited
Loading

  • meta-tegra includes the latest changes in kirkstone
    ̶-̶ ̶m̶e̶t̶a̶-̶l̶m̶p̶ ̶i̶n̶c̶l̶u̶d̶e̶s̶ ̶f̶i̶x̶e̶s̶ ̶f̶o̶r̶ ̶m̶e̶t̶a̶-̶t̶e̶g̶r̶a̶ ̶a̶n̶d̶ ̶o̶e̶-̶c̶o̶r̶e̶ ̶(̶e̶x̶c̶e̶p̶t̶ ̶o̶f̶ ̶a̶m̶6̶x̶x̶x̶x̶ ̶i̶s̶u̶e̶e̶ ̶w̶i̶t̶h̶ ̶s̶p̶d̶x̶)̶

@quaresmajose
Copy link
Member

This is also broken on main-next and I am on it, when fixed I backport the patches to kirkstone

@quaresmajose quaresmajose mentioned this pull request Jan 9, 2023
Merged
@quaresmajose
Copy link
Member

Fixed with foundriesio/meta-lmp#1002

@quaresmajose
Copy link
Member

Fixed with foundriesio/meta-lmp#1002

@MrCry0 foundriesio/meta-lmp#1002 is merged so can you please rebase and also update the layers:

meta-lmp b16da27a
meta-tegra d3b89844

@MrCry0 MrCry0 force-pushed the main-update-tegra branch from 9b46942 to 4b45fe7 Compare January 17, 2023 12:27
@MrCry0
Copy link
Contributor Author

MrCry0 commented Jan 17, 2023

Fixed with foundriesio/meta-lmp#1002

I updated the PR, let's just wait :)

quaresmajose
quaresmajose approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCry0 MrCry0 force-pushed the main-update-tegra branch from 4b45fe7 to 3a26b67 Compare January 17, 2023 17:31
@quaresmajose
Copy link
Member

I prefer to not merge the clang fixes in this PR because they are not need to bump meta-tegra and we don't know yet where it is introduced in oe-core

- f698342e base: non-clangable: don't use llvm-strip in the kernel
- b54bf470 base: non-clangable: don't use llvm-objcopy in the kernel
- 3926dfcd base: non-clangable: u-boot: force gcc

@quaresmajose quaresmajose self-requested a review January 17, 2023 18:33
@MrCry0
Copy link
Contributor Author

MrCry0 commented Jan 17, 2023 •
edited
Loading

I prefer to not merge the clang fixes in this PR because they are not need to bump meta-tegra and we don't know yet where it is introduced in oe-core

Well, it should break nothing, as before the bug was introduced in oe-core we still hadn't used clang tools for kernel.

But you may be right, the atomic rule is against such bumping. I'm dropping these changes.

@quaresmajose
Copy link
Member

quaresmajose commented Jan 18, 2023 •
edited
Loading

Well, it should break nothing, as before the bug was introduced in oe-core we still hadn't used clang tools for kernel.

But you may be right, the atomic rule is against such bumping. I'm dropping these changes.

Think again on this and it can be a wast of time building it again on CI and as this is now merged in meta-lmp we can go with it and I can revert this meta-lmp changes locally to find the root cause of them in oe-core.

quaresmajose
quaresmajose approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCry0
Copy link
Contributor Author

MrCry0 commented Jan 18, 2023

@ricardosalveti don't you mind?

@ricardosalveti
Copy link
Member

@MrCry0 we updated meta-lmp as part of the meta-ti bump, so we can just update meta-tegra here.

@MrCry0 MrCry0 force-pushed the main-update-tegra branch from 3a26b67 to 664e6ac Compare January 20, 2023 10:58
@MrCry0
Copy link
Contributor Author

MrCry0 commented Jan 20, 2023

@ricardosalveti updated

@quaresmajose
Copy link
Member

quaresmajose commented Jan 20, 2023 •
edited
Loading

The latest a20e9664 meta-tegra kirkstone needs some adaptation that I am fixing now.
The last revision of this bump d3b89844 is ok to merge.

@MrCry0
lmp-bsp: update meta-tegra layer
a4fe3ee 
Relevant changes:
- d3b89844 tegra-helper-scripts: fix Orin detection in brcid-to-uid
- 1350cfab tegra-helper-scripts: nvflashxmlparse: fix GPT checks
- 7e34bc4e tegra-helper-scripts: port initrd-flash updates from R32.7.x
- 5e673ce6 tegra-helper-scripts: port make-sdcard improvements from R32.7.x
- 113b7f4b tegra-flash-init: add BCT redundant copies to mmcblk0boot0 writes
- 1099a25e tegra-configs: Fix RDEPENDS remove of bash from tegra-configs-bootloader
- 5bebc9e5 tegra-helper-scripts: fix post-signing flashcmd.txt fixup in tegra194-flash-helper
- 32479722 tegra-helper-scripts: minor initrd-flash improvements
- e4e663f1 tegra-helper-scripts: fix SoC detection in brcid-to-uid script
- dd0606b2 tegra-helper-scripts: keep inter-element whitespace on XML rewrites
- 94144524 tegra-helper-scripts: allow --extract to take generic types
- cb747fe8 tegra-flash-init: add dump of partition table to logs
- 2786d8f2 tegra-helper-scripts: improve make-sdcard handling of internal storage
- 5c00cff7 tegra-helper-scripts: fix xusb-fw signing in flash helpers
- 65d10b23 tegra-helper-scripts: fix doflash.sh overwrites in initrd-flash script
- 5b19612f image_types_tegra: update __pycache__ cleanup after signing
- 4e494010 tegra-helper-scripts: fix initrd-flash write error handling
- 61d0463d image_types_tegra: updates for initrd flashing
- 9da4d832 tegra-bootfiles: add support for external flash layout files
- 9388bad2 conf/machine: updates for initrd flashing support
- ef4d78e6 tegra-minimal-init: add retries for locating APP partition label
- 8a58e56c tegra-initrd-flash-initramfs: add recipe
- f27b41e2 tegra-flash-init: add recipe for supporting initrd flashing
- 76d2d6d5 libusbgx-tegra-initrd-flash: add recipe
- 72806c75 libconfig-tegra: add recipe
- 9c000cf7 tegra-flash-reboot: add recipe
- 30874465 tegra-helper-scripts-native: Add initrd flashing support
- 2e9cda5c image_types_tegra: update recovery kernel partition size for R35.1
- afa6b397 tegra-libraries-glxcore: Add libxcb-glx to RDEPENDS
- 4142b541 cuda: Provide target arch path override
- ffc9e132 cuda: Use soft assignment for license variables
- ad5edee2 l4t_deb_pkgfeed.bbclass: Add SKIP_POOL_APPEND option
- e6f91d41 conf/machine: Use soft assign for TEGRA_CUDA_ARCHITECTURE

Signed-off-by: Oleksandr Suvorov <[email protected]>
@MrCry0 MrCry0 force-pushed the main-update-tegra branch from 664e6ac to a4fe3ee Compare January 20, 2023 12:36
@quaresmajose quaresmajose mentioned this pull request Jan 20, 2023
Merged
@quaresmajose
Copy link
Member

The latest a20e9664 meta-tegra kirkstone needs some adaptation that I am fixing now.
The last revision of this bump d3b89844 is ok to merge.

@MrCry0 Fixed with foundriesio/meta-lmp#1012

quaresmajose
quaresmajose approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti
Copy link
Member

Will merge this one and create another pr for bumping to the latest tegra/lmp.

@ricardosalveti ricardosalveti merged commit cd611ad into foundriesio:main Jan 23, 2023
@MrCry0 MrCry0 deleted the main-update-tegra branch January 26, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quaresmajose quaresmajose quaresmajose approved these changes

@ricardosalveti ricardosalveti Awaiting requested review from ricardosalveti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrCry0 @quaresmajose @ricardosalveti