fix(git): Use absolute path instead

Signed-off-by: Eric Bode <[email protected]>

subcommands/common.go

@@ -6,6 +6,7 @@ import (
 	"io"
 	"os"
 	"path/filepath"
+	"strings"
 	"text/tabwriter"
 
 	"github.com/cheynewallace/tabby"
@@ -292,3 +293,7 @@ func ShowPages(showPage int, next *string) {
 		fmt.Println()
 	}
 }
+
+func EncodeWhiteSpace(str string) string {
+	return strings.ReplaceAll(str, " ", "\\ ")
+}

subcommands/git/cmd.go

@@ -65,6 +65,7 @@ func findSelf() string {
 func doGitCreds(cmd *cobra.Command, args []string) {
 	self := findSelf()
 
+	var credsPath = cmd.Flags().Lookup("creds-path")
 	sudoer := os.Getenv("SUDO_USER")
 	var execCommand string
 	var gitUsernameCommandArgs []string
@@ -73,10 +74,16 @@ func doGitCreds(cmd *cobra.Command, args []string) {
 	helperName := "fio"
 	dst := filepath.Join(helperPath, GIT_CREDS_HELPER)
 	if runtime.GOOS == "windows" {
+		// To get around edge cases with git on Windows we use the absolute path
+		// So for example the following path will be used: C:/Program\\ Files/Git/bin/git-credential-fio.exe
 		dst += ".exe"
-		helperName += ".exe"
+		helperName = filepath.ToSlash(dst)
+	} else if credsPath.Changed {
+		helperName = dst
 	}
 
+	helperName = subcommands.EncodeWhiteSpace(helperName)
+
 	if len(sudoer) > 0 {
 		u, err := user.Lookup(sudoer)
 		subcommands.DieNotNil(err)