fix: update dataclass objects directly instead of creating new variables #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mehant Kammakomati <[email protected]>
kmehant
requested review from
anhuong,
Ssukriti,
aluu317 and
fabianlim
as code owners
|
Thanks for making a pull request! 😃 |
|
LGTM. |
There was a problem hiding this comment.
This looks good to me. Additionally PR #399 also ignored using max_seq_len from function process_dataargs. Thanks @kmehant @dushyantbehl for the fix and cleanup.
ashokponkumar
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was spread of information in multiple variables, therefore confining the source of truth to a single variable, preferably with dataclass objects in this scenario.
cc: @dushyantbehl