-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Release v2.2.0 #404
Merged
Merged
+1,857
−833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
Loading status checks…
…398) Signed-off-by: Dushyant Behl <[email protected]>
* Add initial implementation of dataloader v1 Signed-off-by: Dushyant Behl <[email protected]> * tests: reformat mock.patch to inside unit tests Signed-off-by: Will Johnson <[email protected]> fmt Signed-off-by: Will Johnson <[email protected]> * Add data config argument to data preprocessor Signed-off-by: Dushyant Behl <[email protected]> * fix: Changes to support current implementation Signed-off-by: Abhishek <[email protected]> * Ensure data handling is done within process dataargs Removes unused dead code after adding the new framework and refactors some test cases and files. Signed-off-by: Dushyant Behl <[email protected]> * Remove accelerator in favor of torch distributed check for multi node data preprocessing Signed-off-by: Dushyant Behl <[email protected]> * Refactor data util tests as data handler tests. Signed-off-by: Dushyant Behl <[email protected]> * fix: add __init__.py to add tuning.data to python package Signed-off-by: Will Johnson <[email protected]> * fix: multi GPU prepare training dataset Signed-off-by: Will Johnson <[email protected]> * fix: lint Signed-off-by: Will Johnson <[email protected]> * fix: Add TODO Signed-off-by: Will Johnson <[email protected]> * test: add test for process_dataset_configs in HFBasedDataPreProcessor Signed-off-by: Will Johnson <[email protected]> * add: test cases for framework Signed-off-by: Abhishek <[email protected]> * fix: update function name get_dataprocessor->get_datapreprocessor Signed-off-by: Will Johnson <[email protected]> * Rename loader to processor Signed-off-by: Dushyant Behl <[email protected]> * data folders should be together Signed-off-by: Dushyant Behl <[email protected]> * Add code comments and make code path clearer. Remove packing check as packing support for pretokenised data is merged to trl. See huggingface/trl#2011 Signed-off-by: Dushyant Behl <[email protected]> --------- Signed-off-by: Dushyant Behl <[email protected]> Signed-off-by: Will Johnson <[email protected]> Signed-off-by: Abhishek <[email protected]> Co-authored-by: Will Johnson <[email protected]> Co-authored-by: Abhishek <[email protected]>
Signed-off-by: Abhishek <[email protected]>
Thanks for making a pull request! 😃 |
willmj
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commits look correct to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v2.2.0 of
fms-hf-tuning