Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SCANOSS Invocation Method from Command Line to Library Function #178

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

YongGoose
Copy link
Contributor

@YongGoose YongGoose commented Jul 31, 2024

Description

  • Refactor to use SCANOSS library directly
  • Remove deprecated pkg_resources usage

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related Issue

@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Aug 3, 2024
@soimkim
Copy link
Contributor

soimkim commented Aug 3, 2024

https://github.com/LGE-OSS/example 소스를 다운로드 받고 분석을 실행하면 이전 버전에서는 ScanOSS로 검출되는 파일 수가 2702개 이나, 본 PR에서는 1개도 검출되지 않습니다.
테스트 방법

1. git clone https://github.com/LGE-OSS/example
2. cd example
3. example$ fosslight_source -s scanoss

@YongGoose
Copy link
Contributor Author

https://github.com/LGE-OSS/example 소스를 다운로드 받고 분석을 실행하면 이전 버전에서는 ScanOSS로 검출되는 파일 수가 2702개 이나, 본 PR에서는 1개도 검출되지 않습니다. 테스트 방법

1. git clone https://github.com/LGE-OSS/example
2. cd example
3. example$ fosslight_source -s scanoss

@soimkim
파일이 검출 되도록 수정했습니다!
확인 부탁드립니다.

@soimkim soimkim merged commit 32deddd into fosslight:main Aug 5, 2024
7 checks passed
@soimkim soimkim linked an issue Aug 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change SCANOSS Invocation Method from Command Line to Library Function
2 participants