-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Docker support and add Windows executable for FossLight Scanner #123
Open
soonhong99
wants to merge
7
commits into
fosslight:main
Choose a base branch
from
soonhong99:docker-support-and-windows-exe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhance Docker support and add Windows executable for FossLight Scanner #123
soonhong99
wants to merge
7
commits into
fosslight:main
from
soonhong99:docker-support-and-windows-exe
+313
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecutable for easier volume mounting * refactor: Update Dockerfile to handle -p and -o options without errors * feat: Implement fosslight_wrapper.py to simplify Docker volume mounting process * ci: Add GitHub Actions workflow to create Windows executable using PyInstaller on release Signed-off-by: soonhong99 <[email protected]>
#122 docker automated release에 이은 PR입니다. |
Signed-off-by: soonhong99 <[email protected]>
Signed-off-by: soonhong99 <[email protected]>
ParkSangsin
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
Hosim33
approved these changes
Sep 22, 2024
persi0815
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5 tasks
Signed-off-by: soonhong99 <[email protected]>
리뷰 요청하실 때, Ready for review 클릭해주십시오. |
Signed-off-by: soonhong99 <[email protected]>
…oonhong99/fosslight_scanner into docker-support-and-windows-exe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two main improvements to the FossLight Scanner:
Docker Support Enhancement:
-p
and-o
options without throwing errors.Windows Executable Creation:
fosslight_wrapper.py
, a Python script that simplifies the process of using FossLight Scanner with Docker on Windows.fosslight_wrapper.py
using PyInstaller when a new release is published.These improvements aim to enhance user experience, particularly for Windows users, and make the FossLight Scanner more accessible and easier to use across different environments.
Testing Process
Docker functionality:
-p
and-o
options, ensuring no errors occur.Windows executable:
Cross-platform testing:
Type of change
Please insert 'x' one of the type of change.