Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting.json with source_scanner selection #109

Merged
merged 23 commits into from
Aug 30, 2024
Merged

Conversation

soonhong99
Copy link
Contributor

@soonhong99 soonhong99 commented Jul 21, 2024

Description

This PR introduces several enhancements to the FOSSLight Scanner's functionality and improvements to code quality:

Source Scanner Option Enhancements:

  • Added a new argument for selective source scanner usage

  • Implemented source scanner option -j in setting.json, supporting raw result generation in JSON format

Code Cleanup and Optimization:

  • Removed unused annotations

  • Simplified code by deleting unnecessary parameters

Error Fixes and Style Improvements:

  • Resolved tox-related errors

  • Modified code to adhere to flake8 style guidelines

These changes improve the flexibility of FOSSLight Scanner and enhance the code's readability and maintainability. In particular, the improvements to source scanner options provide users with more control, while the JSON format raw result generation feature facilitates additional analysis and integration work.

Test Results:

  • Ran unit tests and integration tests for all changes

  • Verified error-free execution in the tox testing environment

  • Passed flake8 inspection, maintaining code style consistency

Reviewers are kindly requested to focus particularly on the implementation of the new source scanner options and the changes to setting.json.

Type of change

Please insert 'x' one of the type of change.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soonhong99 soonhong99 marked this pull request as draft July 21, 2024 07:51
@soonhong99 soonhong99 changed the title Setting.json with source_scanner selection #101 Setting.json with source_scanner selection Jul 21, 2024
@soonhong99 soonhong99 marked this pull request as ready for review July 31, 2024 15:10
@soonhong99
Copy link
Contributor Author

setting.json 관련 scanner source -s 옵션 구현 완료 하였습니다.

확인해주세요~

@soonhong99
Copy link
Contributor Author

setting.json 관련 scanner source -j 옵션 구현 완료 하였습니다.

Can Generate raw result of scanners in json format At Your Setting.json

@soimkim soimkim added the enhancement [PR/Issue] New feature or request label Aug 3, 2024
setting.json Outdated Show resolved Hide resolved
@soimkim
Copy link
Contributor

soimkim commented Aug 3, 2024

PR의 Description에 수정한 사항에 대한 설명을 작성해주십시오.

@soimkim
Copy link
Contributor

soimkim commented Aug 3, 2024

Conflict resolve해주시고, tox -e release시 에러가 없는지 확인해주십시오. (컨벤션 룰 에러도 출력됩니다.)

@soonhong99
Copy link
Contributor Author

관련 내역 수정 완료 및 description 부분에 코드 설명 넣어놨습니다.

tests/setting.json Outdated Show resolved Hide resolved
@soonhong99
Copy link
Contributor Author

관련 내용 확인 및 수정 완료 하였습니다.

@soonhong99
Copy link
Contributor Author

FL binary --notice 옵션에서 print license 뿐만 아닌 setting.json에서 output으로 설정한 폴더명에 license가 txt로 저장되게끔 구현하였습니다.

@soimkim
Copy link
Contributor

soimkim commented Aug 18, 2024

test_src 폴더 삭제 부탁드립니다.

test_src/test.py Outdated Show resolved Hide resolved
@soonhong99
Copy link
Contributor Author

관련 내용 수정 완료하였습니다.

src/fosslight_scanner/_parse_setting.py Outdated Show resolved Hide resolved
src/fosslight_scanner/cli.py Outdated Show resolved Hide resolved
src/fosslight_scanner/cli.py Outdated Show resolved Hide resolved
@soonhong99
Copy link
Contributor Author

관련 내용 수정 하였습니다.

@soimkim
Copy link
Contributor

soimkim commented Aug 29, 2024

@soonhong99 ,
수정 완료된 사항에는 커맨트 남겨주시고 Resolve conversation 클릭 부탁드려요.
image

@soonhong99
Copy link
Contributor Author

soonhong99 commented Aug 29, 2024

image
resolve를 눌렀는데 커멘트를 안날리면 resolve가 되지 않나요?
우선 커멘트도 날렸습니다. + unresolved 되어있던 커멘트도 resolve하였습니다.

@soimkim
Copy link
Contributor

soimkim commented Aug 30, 2024

커맨트 안 남겨도 Resolve 누르시면 resolve처리됩니다. 😃

@soimkim soimkim merged commit 9603cdd into fosslight:main Aug 30, 2024
5 of 6 checks passed
@soimkim
Copy link
Contributor

soimkim commented Aug 30, 2024

fosslight_source에 대해 path_to_exclude가 적용 안 되는 파생 버그가 있음-> fosslight_source쪽 버그 인듯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [PR/Issue] New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants