fix: Align search bar in the date-list container #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 6, 2020
src/backend/_scss/application.scss
Outdated
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Files should end with a trailing newline
src/backend/_scss/application.scss
Outdated
| label { | ||
| display: inline; | ||
|
|
||
| .fa { |
There was a problem hiding this comment.
Nesting should be no greater than 4, but was 5
Selector should have depth of applicability no greater than 4, but was 5
src/backend/_scss/application.scss
Outdated
| .search-filter { | ||
| label { | ||
| display: inline; | ||
|
|
src/backend/_scss/application.scss
Outdated
| @@ -2469,3 +2469,17 @@ a.skip:hover { | |||
| display: none; | |||
| } | |||
| } | |||
|
|
|||
| .date-list { | |||
There was a problem hiding this comment.
Merge rule .date-list with rule on line 625
dhruvjain99
force-pushed
the
bug-search-bar-layout
branch
from
c6a937c to
c238a6e
Compare
houndci-bot
reviewed
Nov 6, 2020
| .date-list-search-filter { | ||
| label { | ||
| display: inline; | ||
| .fa { |
There was a problem hiding this comment.
Rule declaration should be preceded by an empty line
dhruvjain99
force-pushed
the
bug-search-bar-layout
branch
from
c238a6e to
cedbc04
Compare
|
@iamareebjamal can you please review this PR? |
iamareebjamal
changed the title
|
Please follow PR title guidelines |
iamareebjamal
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
developmentbranch.Short description of what this resolves:
Aligns the search bar which was out of place earlier.
Before the change:
After the change:
Changes proposed in this pull request:
Fixes #2214