Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Re-enable checking broken links in sponsors section #2372

Conversation

dhruvjain99
Copy link
Contributor

@dhruvjain99 dhruvjain99 commented Oct 29, 2020

Fixes #2362

- Earlier the test was on FossasiaSummit2017 in which one sponsor link was broken so the test failed
- Now we are checking for MozillaAllHands2017 so the test is moved after eventPage visits the MozillaAllHands2017 site

@@ -188,7 +188,7 @@ describe("Running Selenium tests on Chrome Driver", function() {
});
});

xit('Checking broken links in of Sponsors section', function(done) {
it('Checking broken links in of Sponsors section', function(done) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'it' is not defined no-undef

…llHands2017 event

- Earlier the test was on FossasiaSummit2017 in which one sponsor link was broken so the test failed
- Now we are checking for MozillaAllHands2017 so the test is moved after eventPage visits the MozillaAllHands2017 site

Fixes fossasia#2362
@dhruvjain99 dhruvjain99 force-pushed the re-enable-event-sponsor-link-test branch from a0f5ba9 to c02d060 Compare October 30, 2020 07:55
@@ -224,6 +215,14 @@ describe("Running Selenium tests on Chrome Driver", function() {
});
});

it('Checking broken links in of Sponsors section', function(done) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'it' is not defined no-undef

@dhruvjain99
Copy link
Contributor Author

@iamareebjamal can you please review?

@iamareebjamal iamareebjamal changed the title Ref: Re-enable checking broken links in sponsors section chore: Re-enable checking broken links in sponsors section Oct 30, 2020
@iamareebjamal iamareebjamal merged commit acdbc05 into fossasia:development Oct 30, 2020
@auto-label auto-label bot added the chore label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix and re-enable sponsor link test
3 participants