fix: Remove unwanted space in speaker name list #2366
Conversation
…if speaker position(job title) is not specified - Add a conditional to check if position is passed Fixes #2249
|
My second commit is for the next issue #2253 |
|
Do let me know if we need to merge this commit and then raise a separate PR for the next issue. |
|
@iamareebjamal I have made the changes and raised the PR, whom do I need to add as reviewers? |
|
Before and after screenshots |
Fixes #2249If a speaker adds both title and company things look fine on the schedule and tracks page. But, if a speaker does not add a job title there is an unwanted space after brackets. After the changes The above changes are fixed in commit #f66f32cade04d4668eae2461a5414cc87220f5d2 (i.e. the first commit) |
src/backend/templates/schedule.hbs
Outdated
| {{/ifcontains}} | ||
| {{#ifvalue description notequals=""}} | ||
| <hr class="clear-both"> | ||
| {{/ifvalue}} | ||
| <div id="speaker-{{session_id}}" class="session-speakers-list" |
There was a problem hiding this comment.
why are those lines moved around? Please only change lines that are related to the issue.
There was a problem hiding this comment.
@mariobehling These lines are moved to resolve issue #2253. I was waiting for this PR(for issue #2366) to get reviewed and in the meantime, I resolved issue #2253 and made a commit to the development branch, and pushed it to the origin. So the second commit change automatically got added in this PR. Shall I roll back the above change for now and raise another PR after this one gets merged?
There was a problem hiding this comment.
yes, please make the changes in separate PRs. Thanks
src/backend/templates/tracks.hbs
Outdated
| <source src="{{ audio }}"> | ||
| </audio> | ||
| {{/ifcontains}} | ||
| <hr class="clear-both"> | ||
| <div id="speaker-{{session_id}}" class="session-speakers-list" aria-expanded="false" |
There was a problem hiding this comment.
why are those lines moved around? Please only change lines that are related to the issue.
There was a problem hiding this comment.
@mariobehling These lines are moved to resolve issue #2253. I was waiting for this PR(for issue #2366) to get reviewed and in the meantime, I resolved issue #2253 and made a commit to the development branch, and pushed it to the origin. So the second commit change automatically got added in this PR. Shall I roll back the above change for now and raise another PR after this one gets merged?
There was a problem hiding this comment.
correct, only make changes in a PR which corresponds to the issue.
|
@mariobehling I have rollbacked the unwanted changes (which were pertaining to a different issue). Can you please check now? |
iamareebjamal
changed the title
Fix: Remove unwanted space after round brackets in speaker name list if speaker position(job title) is not specified
Fixes #2249