Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove additional parameters for is_paytm_activated(schema) #6357

Merged
merged 1 commit into from
Aug 13, 2019
Merged

fix: remove additional parameters for is_paytm_activated(schema) #6357

merged 1 commit into from
Aug 13, 2019

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Aug 13, 2019 •
edited
Loading

Fixes #6356
Related: fossasia/open-event-frontend#3385

Short description of what this resolves:

Removes dump_only property to enable write ability to the DB.

@auto-label auto-label bot added the fix label Aug 13, 2019
@mrsaicharan1
Copy link
Member Author

@iamareebjamal @uds5501 @shreyanshdwivedi Please review.

@mrsaicharan1 mrsaicharan1 mentioned this pull request Aug 13, 2019
Merged
kushthedude
kushthedude previously approved these changes Aug 13, 2019
View reviewed changes
uds5501
uds5501 previously approved these changes Aug 13, 2019
View reviewed changes
@mrsaicharan1 mrsaicharan1 dismissed stale reviews from uds5501 and kushthedude via fdd5090 August 13, 2019 07:34
@mrsaicharan1 mrsaicharan1 changed the title fix: remove dump_only for is_paytm_activated fix: remove additional parameters for is_paytm_activated(schema) Aug 13, 2019
@mrsaicharan1
Copy link
Member Author

@shreyanshdwivedi @uds5501 @kushthedude PLease have a look. Removed the allow_none param too.

@codecov
Copy link

codecov bot commented Aug 13, 2019 •
edited
Loading

Codecov Report

Merging #6357 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6357   +/-   ##
============================================
  Coverage        65.38%   65.38%           
============================================
  Files              287      287           
  Lines            14725    14725           
============================================
  Hits              9628     9628           
  Misses            5097     5097
Impacted Files Coverage Δ
app/api/schema/settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e6a77...fdd5090. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 1a02987 into fossasia:development Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@uds5501 uds5501 uds5501 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@prateekj117 prateekj117 prateekj117 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_paytm_activated shouldn't be a read only attribute
6 participants
@mrsaicharan1 @iamareebjamal @uds5501 @shreyanshdwivedi @prateekj117 @kushthedude