-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhance session card in schedule page #5809
fix: enhance session card in schedule page #5809
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/bpttboyrj |
Make it smaller and less highlighted than the name |
Codecov Report
@@ Coverage Diff @@
## development #5809 +/- ##
============================================
Coverage 23.37% 23.37%
============================================
Files 511 511
Lines 5472 5472
Branches 65 65
============================================
Hits 1279 1279
Misses 4176 4176
Partials 17 17 Continue to review full report at Codecov.
|
Change the opacity of speaker designation (below the name) to 0.8 and font size to .9rem Also, since names are not grouped now, remove the paranthesis |
Also add ml-2 to speaker name and designation div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comma issue has been solved in another PR now. Please resolve conflicts. |
@sachinchauhan2889 @daretobedifferent18 We want this to be part of 1.19.0 release, which is blocked due to this, so, tomorrow, please work together to iron out the few layout issues as soon as possible so we can release 1.19.0 Thanks |
@iamareebjamal sir, please review |
<i class="icon {{if this.slidesUploaded 'download' 'linkify'}}"></i> | ||
{{if this.slidesUploaded (t 'Download Slides') (t 'Link to Slides')}} | ||
</button> | ||
<div style="white-space: nowrap;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wrap in this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<i class="icon video"></i> | ||
{{t 'Join Video'}} | ||
</button> | ||
<div style="white-space: nowrap;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wrap in this?
Merging branch to see if that fixes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Button is there after branch merge. Thank you
Fixes #5787
Fixes #5797
Short description of what this resolves:
screenshots
Checklist
development
branch.