Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: position of logout icon in other languages #5722

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5721

Short description of what this resolves:

fix position of logout icon in other languages

Screenshots
before
sachin2

after

sachin1

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/b7pstsjfu
✅ Preview: https://open-event-frontend-git-logout-button.eventyay.vercel.app

@iamareebjamal
Copy link
Member

iamareebjamal commented Nov 23, 2020

space between isnt good. Use d-flex on container and ml-auto on icon

@sachinchauhan2889
Copy link
Contributor Author

space between isnt good. Use d-flex on container and ml-auto on icon

@iamareebjamal sir, not working. ml-auto is overrided.

sachin3

@iamareebjamal
Copy link
Member

Use inline style. And please check your gitter

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #5722 (f0e9a4c) into development (490fc6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5722   +/-   ##
============================================
  Coverage        23.61%   23.61%           
============================================
  Files              510      510           
  Lines             5420     5420           
  Branches            59       59           
============================================
  Hits              1280     1280           
  Misses            4124     4124           
  Partials            16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490fc6b...f0e9a4c. Read the comment docs.

@sachinchauhan2889
Copy link
Contributor Author

@iamareebjamal sir, ready for review.

@iamareebjamal iamareebjamal changed the title fix: fix position of logout icon in other languages fix: position of logout icon in other languages Nov 24, 2020
@iamareebjamal iamareebjamal merged commit 25eb30b into fossasia:development Nov 24, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the logout-button branch November 24, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top Menu: Log out menu icon disappears in other languages
2 participants