Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add status "Withdrawn" and "canceled" into sessions and speakers column #5671

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5010

required fossasia/open-event-server#7453

Short description of what this resolves:

On the events dashboard at https://eventyay.com/events/live in the speakers and sessions column the status "Withdrawn" and "Canceled" are missing. This PR add them.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screenshots

r1

@vercel
Copy link

vercel bot commented Nov 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9t7tm50m5
✅ Preview: https://open-event-frontend-git-fix-5010.eventyay.vercel.app

@sachinchauhan2889 sachinchauhan2889 changed the title fix-5010 fix: Add status "Withdrawn" into sessions and speakers column in Organizer Events Dashboard Nov 17, 2020
@auto-label auto-label bot added the fix label Nov 17, 2020
@sachinchauhan2889 sachinchauhan2889 changed the title fix: Add status "Withdrawn" into sessions and speakers column in Organizer Events Dashboard fix: Add status "Withdrawn" and "canceled" into sessions and speakers column in Organizer Events Dashboard Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #5671 (0342c40) into development (0c0c8cf) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5671      +/-   ##
===============================================
- Coverage        23.79%   23.72%   -0.07%     
===============================================
  Files              498      498              
  Lines             5275     5277       +2     
  Branches            47       47              
===============================================
- Hits              1255     1252       -3     
- Misses            4012     4017       +5     
  Partials             8        8              
Impacted Files Coverage Δ
app/serializers/event-statistics-general.js 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6337818...0342c40. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix: Add status "Withdrawn" and "canceled" into sessions and speakers column in Organizer Events Dashboard fix: Add status "Withdrawn" and "canceled" into sessions and speakers column Nov 17, 2020
@iamareebjamal iamareebjamal merged commit b2c158b into fossasia:development Nov 17, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the fix-5010 branch November 17, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer Events Dashboard: Add status "Withdrawn" into sessions and speakers column in table
2 participants