fix: Only show country dropdown without autocomplete #5652

divyamtayal · 2020-11-15T23:10:36Z

Fixes #5438

Short description of what this resolves:

The problem was that all the countries which are defined in demography were showing. Now showing only payment countries

Changes proposed in this pull request:

Instead of showing all countries showing payment countries.

Before

After

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-11-15T23:10:41Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/nibnrl3rq
✅ Preview: https://open-event-frontend-git-only-countries-5438.eventyay.now.sh

codecov · 2020-11-15T23:22:35Z

Codecov Report

Merging #5652 (6f25411) into development (7d00804) will decrease coverage by 0.15%.
The diff coverage is 50.00%.

@@               Coverage Diff               @@
##           development    #5652      +/-   ##
===============================================
- Coverage        23.73%   23.57%   -0.16%     
===============================================
  Files              509      510       +1     
  Lines             5415     5417       +2     
  Branches            59       59              
===============================================
- Hits              1285     1277       -8     
- Misses            4114     4124      +10     
  Partials            16       16

Impacted Files	Coverage Δ
app/components/country-dropdown.ts	`50.00% <50.00%> (ø)`
app/components/smart-overflow.js	`61.53% <0.00%> (-38.47%)`	⬇️
app/components/modals/tax-info-modal.js	`11.11% <0.00%> (-11.12%)`	⬇️
app/controllers/index.js	`27.27% <0.00%> (-9.10%)`	⬇️
app/components/forms/user-payment-info-form.js	`20.00% <0.00%> (-6.67%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d00804...20cdc1a. Read the comment docs.

divyamtayal · 2020-11-16T00:46:05Z

@iamareebjamal Please see the changes I have made.

iamareebjamal · 2020-11-16T02:15:42Z

app/components/forms/user-payment-info-form.js

@@ -96,6 +97,10 @@ export default class UserPaymentInfoForm extends Component.extend(FormMixin) {
    return orderBy(countries, 'name');
  }

+  get paymentCountries() {
+    return orderBy(filter(countries, country => paymentCountries.includes(country.code)), 'name');


Use js native filter

iamareebjamal · 2020-11-16T02:16:18Z

This does not solve the issue. Read the issue again

divyamtayal · 2020-11-16T02:33:30Z

@iamareebjamal the issue what I think is that while for eg searching for India they are lots of countries coming, so do I have to not show other unnecessary countries in drop down o and not change anything with no of countries that are already there in it.

Bcz like for eg in wizard step 1 during choosing country there are only 44 countries in the dropdown but here there are 200+ so if we search India for eg here it will be showing more no. of countries bcz here in UiDropwdown we are using fullTextSearch={{true}}
and what I found is this

so either the best option could be instead of using false use true and not changes the list of countries

iamareebjamal · 2020-11-16T03:52:20Z

That's not the issue. Please read it again, carefully. See the linked PR and the PR I have mentioned there

divyamtayal · 2020-11-16T15:39:10Z

That's not the issue. Please read it again, carefully. See the linked PR and the PR I have mentioned there

@iamareebjamal I understood the issue, pls clear me out do I have to turn autocomplete='off' for entire form or just for country dowpdown bcz as you mentioned in tax-info-modal autocomplete='off' is for entire form.
And also should I revert back the changes made till now.
Please let me know this.

iamareebjamal · 2020-11-17T00:53:15Z

The issue mentions in the title - only country

And I have mentioned it in the linked PR as well

divyamtayal · 2020-11-17T07:10:01Z

@iamareebjamal Please see the changes made.

app/templates/components/forms/user-payment-info-form.hbs

app/components/forms/user-payment-info-form.js

iamareebjamal · 2020-11-17T11:16:54Z

Still getting autocomplete

divyamtayal · 2020-11-17T11:18:51Z

Still getting autocomplete

@iamareebjamal can u pls share the screenshot

app/templates/components/country-dropdown.hbs

app/components/country-dropdown.ts

app/templates/components/country-dropdown.hbs

app/templates/components/forms/wizard/basic-details-step.hbs

…erent18/open-event-frontend into only-countries-5438

app/components/country-dropdown.ts

Show Payment countries only

8bc8dd9

vercel bot deployed to Preview November 15, 2020 23:10 View deployment

Merge branch 'development' into only-countries-5438

3fd3e20

divyamtayal changed the title ~~Show Payment countries only~~ Only show country dropdown, do not automatically fill in random info - only country Nov 15, 2020

vercel bot deployed to Preview November 15, 2020 23:14 View deployment

iamareebjamal reviewed Nov 16, 2020

View reviewed changes

autoComplete-off

30fa5eb

vercel bot deployed to Preview November 17, 2020 07:07 View deployment

Merge branch 'development' into only-countries-5438

c00e2dc

divyamtayal requested a review from iamareebjamal November 17, 2020 07:10

vercel bot deployed to Preview November 17, 2020 07:11 View deployment

iamareebjamal reviewed Nov 17, 2020

View reviewed changes

app/templates/components/forms/user-payment-info-form.hbs Outdated Show resolved Hide resolved

iamareebjamal reviewed Nov 17, 2020

View reviewed changes

app/components/forms/user-payment-info-form.js Outdated Show resolved Hide resolved

Revert Changes

80f4e08

vercel bot deployed to Preview November 17, 2020 08:18 View deployment

Removed Autocomplete

fb31c0a

vercel bot deployed to Preview November 17, 2020 11:09 View deployment

divyamtayal requested a review from iamareebjamal November 17, 2020 11:12

Merge branch 'development' into only-countries-5438

6bcbe8d

vercel bot deployed to Preview November 19, 2020 14:49 View deployment

Improved code

4bcd9e8

vercel bot deployed to Preview November 19, 2020 15:33 View deployment

divyamtayal requested a review from iamareebjamal November 19, 2020 15:34

Update country-dropdown.ts

7f735e7

vercel bot deployed to Preview November 19, 2020 15:37 View deployment

iamareebjamal reviewed Nov 19, 2020

View reviewed changes

app/templates/components/country-dropdown.hbs Outdated Show resolved Hide resolved

Improved code-1

bb6f3aa

vercel bot deployed to Preview November 19, 2020 15:57 View deployment

iamareebjamal reviewed Nov 19, 2020

View reviewed changes

app/components/country-dropdown.ts Outdated Show resolved Hide resolved

iamareebjamal reviewed Nov 19, 2020

View reviewed changes

app/templates/components/country-dropdown.hbs Show resolved Hide resolved

iamareebjamal reviewed Nov 19, 2020

View reviewed changes

app/templates/components/forms/wizard/basic-details-step.hbs Outdated Show resolved Hide resolved

Code cleanup

f45bce3

vercel bot deployed to Preview November 19, 2020 16:47 View deployment

divyamtayal changed the title ~~Only show country dropdown, do not automatically fill in random info - only country~~ fix: Only show country dropdown, do not automatically fill in random info - only country Nov 19, 2020

auto-label bot added the fix label Nov 19, 2020

Improved code-2

0007745

vercel bot deployed to Preview November 19, 2020 17:01 View deployment

Merge branch 'development' into only-countries-5438

f688a9c

vercel bot deployed to Preview November 19, 2020 18:50 View deployment

daretobedifferent18 added 2 commits November 20, 2020 07:43

Added id

002f4dd

Merge branch 'only-countries-5438' of https://github.com/daretobediff…

6f25411

…erent18/open-event-frontend into only-countries-5438

vercel bot deployed to Preview November 20, 2020 02:14 View deployment

iamareebjamal reviewed Nov 20, 2020

View reviewed changes

app/components/country-dropdown.ts Outdated Show resolved Hide resolved

iamareebjamal reviewed Nov 20, 2020

View reviewed changes

app/components/country-dropdown.ts Outdated Show resolved Hide resolved

f

20cdc1a

vercel bot deployed to Preview November 20, 2020 03:39 View deployment

iamareebjamal changed the title ~~fix: Only show country dropdown, do not automatically fill in random info - only country~~ fix: Only show country dropdown without autocomplete Nov 20, 2020

iamareebjamal merged commit 70c2285 into fossasia:development Nov 20, 2020

divyamtayal deleted the only-countries-5438 branch November 23, 2020 00:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Only show country dropdown without autocomplete #5652

fix: Only show country dropdown without autocomplete #5652

divyamtayal commented Nov 15, 2020 •

edited

Loading

vercel bot commented Nov 15, 2020 •

edited

Loading

codecov bot commented Nov 15, 2020 •

edited

Loading

divyamtayal commented Nov 16, 2020

iamareebjamal Nov 16, 2020

iamareebjamal commented Nov 16, 2020

divyamtayal commented Nov 16, 2020

iamareebjamal commented Nov 16, 2020 •

edited

Loading

divyamtayal commented Nov 16, 2020 •

edited

Loading

iamareebjamal commented Nov 17, 2020

divyamtayal commented Nov 17, 2020

iamareebjamal commented Nov 17, 2020

divyamtayal commented Nov 17, 2020

fix: Only show country dropdown without autocomplete #5652

fix: Only show country dropdown without autocomplete #5652

Conversation

divyamtayal commented Nov 15, 2020 • edited Loading

Short description of what this resolves:

Changes proposed in this pull request:

Before

After

Checklist

vercel bot commented Nov 15, 2020 • edited Loading

codecov bot commented Nov 15, 2020 • edited Loading

Codecov Report

divyamtayal commented Nov 16, 2020

iamareebjamal Nov 16, 2020

Choose a reason for hiding this comment

iamareebjamal commented Nov 16, 2020

divyamtayal commented Nov 16, 2020

iamareebjamal commented Nov 16, 2020 • edited Loading

divyamtayal commented Nov 16, 2020 • edited Loading

iamareebjamal commented Nov 17, 2020

divyamtayal commented Nov 17, 2020

iamareebjamal commented Nov 17, 2020

divyamtayal commented Nov 17, 2020

divyamtayal commented Nov 15, 2020 •

edited

Loading

vercel bot commented Nov 15, 2020 •

edited

Loading

codecov bot commented Nov 15, 2020 •

edited

Loading

iamareebjamal commented Nov 16, 2020 •

edited

Loading

divyamtayal commented Nov 16, 2020 •

edited

Loading