-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Move and simplify "Event Types" #5651
fix: Move and simplify "Event Types" #5651
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/863dqlcre |
@iamareebjamal Please see the changes I have made. |
Codecov Report
@@ Coverage Diff @@
## development #5651 +/- ##
===============================================
- Coverage 23.79% 23.73% -0.06%
===============================================
Files 498 498
Lines 5275 5275
Branches 47 47
===============================================
- Hits 1255 1252 -3
- Misses 4012 4015 +3
Partials 8 8
Continue to review full report at Codecov.
|
Please don't take up issues labeled 'project', they're for the freelancer |
@iamareebjamal next time I will take care of that, I was not knowing. but for nowI have already worked on it, can u review and if ok merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please also do the following in this PR:
- Adjust the box design to match the other boxes in the areas (Compare to the Timezone box)
- Make the box height the same as the other one-line boxes
- Make the spacing of the text the same as in the other boxes (in particular the spacing on the left side)
Please also make the box line the same as the other boxes. Basically you could just reuse the design of the timezone box entirely. Thanks. |
@mariobehling That's a different component from semantic UI component because semantic UI component does not work with items with |
@iamareebjamal should i make any changes now bcz this is entirely different component than UiDropdown. So pls let me know? |
@iamareebjamal @mariobehling Please see the changes made. |
@iamareebjamal PLease see the changes |
When you are editing it anyway, why not make it the same size as the dropdown height? And change the color to grey like timezone dropdown. It still doesn't feel right that the field itself is twice as high as the options |
$ember-power-select-highlighted-background for color and you already know how to change height |
@iamareebjamal Please see the changes |
Perfect, thanks |
Fixes #5014
Short description of what this resolves:
Moved up Event Types
Changes proposed in this pull request:
ScreenShots
(Mobile View)
Checklist
development
branch.