Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket Icon Changed #5634

Closed

Conversation

Saumyachitransh01
Copy link
Member

@Saumyachitransh01 Saumyachitransh01 commented Nov 15, 2020

Order page
Screenshot from 2020-11-15 15-27-52
Complete Order page
Screenshot from 2020-11-15 15-31-12

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/egowvajcn
✅ Preview: https://open-event-frontend-git-ticket.eventyay.vercel.app

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a PR for this #5625

@sachinchauhan2889
Copy link
Contributor

Already having PR for #5624.

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #5634 (17e8499) into development (5bbb10c) will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5634      +/-   ##
===============================================
+ Coverage        23.25%   23.73%   +0.48%     
===============================================
  Files              493      498       +5     
  Lines             5182     5275      +93     
  Branches            38       47       +9     
===============================================
+ Hits              1205     1252      +47     
- Misses            3972     4015      +43     
- Partials             5        8       +3     
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/utils/computed-helpers.js 19.56% <0.00%> (-1.72%) ⬇️
app/components/modals/modal-base.js 24.24% <0.00%> (-0.76%) ⬇️
app/components/widgets/forms/image-upload.js 22.64% <0.00%> (-0.44%) ⬇️
app/routes/index.js 78.57% <0.00%> (ø)
app/models/social-link.js 0.00% <0.00%> (ø)
app/controllers/register.js 34.28% <0.00%> (ø)
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/routes/public/cfs/index.js 0.00% <0.00%> (ø)
app/controllers/admin/users/list.js 0.00% <0.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bbb10c...17e8499. Read the comment docs.

@Saumyachitransh01
Copy link
Member Author

We already have a PR for this #5625

yes but I thought it's better icon for ticket buyer

@snitin315
Copy link
Member

Instead creating a new PR you should suggest changes to the existing PR. 😀

@Saumyachitransh01
Copy link
Member Author

Instead creating a new PR you should suggest changes to the existing PR.

Okay

@Saumyachitransh01 Saumyachitransh01 deleted the ticket branch November 15, 2020 11:08
@Saumyachitransh01 Saumyachitransh01 restored the ticket branch November 17, 2020 05:50
@Saumyachitransh01 Saumyachitransh01 deleted the ticket branch November 17, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants