Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Order Page and Completed Order Page: Change "Go to event" #5617

Merged
merged 3 commits into from
Nov 15, 2020
Merged

fix: Order Page and Completed Order Page: Change "Go to event" #5617

merged 3 commits into from
Nov 15, 2020

Conversation

divyamtayal
Copy link
Member

@divyamtayal divyamtayal commented Nov 13, 2020

Fixes #5616

Short description of what this resolves:

Enhance the Order and complete order page

Changes proposed in this pull request:

  • add a param for compeleted order so that if n only if order is completed then only 'go to event page' link is visible
  • add website icon

ScreenShots

Order Page

Screenshot from 2020-11-14 04-56-02
Complete Order Page

Screenshot from 2020-11-14 04-55-18

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/qn4lqjkdg
✅ Preview: https://open-event-frontend-git-go-to-event-5616.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #5617 (41a552e) into development (117f110) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5617   +/-   ##
============================================
  Coverage        23.73%   23.73%           
============================================
  Files              498      498           
  Lines             5275     5275           
  Branches            47       47           
============================================
  Hits              1252     1252           
  Misses            4015     4015           
  Partials             8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117f110...1b54c23. Read the comment docs.

Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you forgot about first point. please remove empty spaces in between boxes
all other things working fine.

review

@sachinchauhan2889
Copy link
Contributor

you can refer my previous commits for removing empty spaces.
#5561
#5464

@sachinchauhan2889
Copy link
Contributor

I think that is already done in ur PR's but I don't know why is this not updated the code here

i have remove empty space in pr #5618. you can skip this. otherwise this create conflict.

@divyamtayal divyamtayal deleted the go-to-event-5616 branch November 14, 2020 00:39
@divyamtayal divyamtayal restored the go-to-event-5616 branch November 14, 2020 01:02
@divyamtayal divyamtayal reopened this Nov 14, 2020
@divyamtayal divyamtayal changed the title Go to event 5616 Order Page and Completed Order Page: Change "Go to event" Nov 14, 2020
@divyamtayal
Copy link
Member Author

@iamareebjamal PLease see the changes I have made

@divyamtayal
Copy link
Member Author

@iamareebjamal Done

@iamareebjamal iamareebjamal changed the title Order Page and Completed Order Page: Change "Go to event" fix: Order Page and Completed Order Page: Change "Go to event" Nov 15, 2020
@auto-label auto-label bot added the fix label Nov 15, 2020
@iamareebjamal iamareebjamal changed the title fix: Order Page and Completed Order Page: Change "Go to event" fix: Order Page and Completed Order Page: Change "Go to event" Nov 15, 2020
@iamareebjamal iamareebjamal merged commit d2bed98 into fossasia:development Nov 15, 2020
@divyamtayal divyamtayal deleted the go-to-event-5616 branch November 15, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Page and Completed Order Page: Change "Go to event"
3 participants