Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get rid of unsed spaces between boxes in templates of the order page #5606

Merged

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5603

Short description of what this resolves:

remove empty space from new order page.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

before
kaaaatuuuu old

after
kaaaatuuuu

@auto-label auto-label bot added the fix label Nov 13, 2020
@vercel
Copy link

vercel bot commented Nov 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/k6y2n8rub
✅ Preview: https://open-event-frontend-git-order-page-fix.eventyay.vercel.app

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share mobile view screenshots as well?

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #5606 (0b0505f) into development (24a4e19) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5606   +/-   ##
============================================
  Coverage        23.73%   23.73%           
============================================
  Files              498      498           
  Lines             5270     5270           
  Branches            47       47           
============================================
  Hits              1251     1251           
  Misses            4011     4011           
  Partials             8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a4e19...0b0505f. Read the comment docs.

@sachinchauhan2889
Copy link
Contributor Author

Can you share mobile view screenshots as well?

Screenshot_20201113-184727.png

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Thanks!

@iamareebjamal iamareebjamal merged commit bac3868 into fossasia:development Nov 14, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the order-page-fix branch November 14, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Pages: Get rid of unsed spaces between boxes in templates of the order process
4 participants