-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move custom fields in attendee form in the end #5576
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3bv562dnz |
Codecov Report
@@ Coverage Diff @@
## development #5576 +/- ##
===============================================
+ Coverage 23.71% 23.75% +0.04%
===============================================
Files 498 498
Lines 5255 5257 +2
Branches 44 44
===============================================
+ Hits 1246 1249 +3
+ Misses 4003 4002 -1
Partials 6 6
Continue to review full report at Codecov.
|
lodash has a helper method to sort by multiple fields |
export default Component.extend(FormMixin, EventWizardMixin, { | ||
|
||
fixedFields: computed('data.customForms.@each', function() { | ||
return this.data.customForms?.filter(field => field.isFixed); | ||
}), | ||
|
||
editableFields: computed('data.customForms.@each', function() { | ||
return this.data.customForms?.filter(field => !field.isFixed); | ||
const fields = sortBy(this.data.customForms, ['isComplex', 'name']); | ||
return fields?.filter(field => !field.isFixed); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filter and then sort. Also, should name be the second property to be used to sort. Is it like that since before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #5537
Checklist
development
branch.