Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move custom fields in attendee form in the end #5576

Merged
merged 4 commits into from
Nov 11, 2020
Merged

fix: move custom fields in attendee form in the end #5576

merged 4 commits into from
Nov 11, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5537

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Nov 11, 2020
@vercel
Copy link

vercel bot commented Nov 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3bv562dnz
✅ Preview: https://open-event-frontend-git-attendeeform.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #5576 (f180e2a) into development (a0d1679) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5576      +/-   ##
===============================================
+ Coverage        23.71%   23.75%   +0.04%     
===============================================
  Files              498      498              
  Lines             5255     5257       +2     
  Branches            44       44              
===============================================
+ Hits              1246     1249       +3     
+ Misses            4003     4002       -1     
  Partials             6        6              
Impacted Files Coverage Δ
app/components/forms/wizard/attendee-step.js 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d1679...f180e2a. Read the comment docs.

@iamareebjamal
Copy link
Member

lodash has a helper method to sort by multiple fields

export default Component.extend(FormMixin, EventWizardMixin, {

fixedFields: computed('data.customForms.@each', function() {
return this.data.customForms?.filter(field => field.isFixed);
}),

editableFields: computed('data.customForms.@each', function() {
return this.data.customForms?.filter(field => !field.isFixed);
const fields = sortBy(this.data.customForms, ['isComplex', 'name']);
return fields?.filter(field => !field.isFixed);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter and then sort. Also, should name be the second property to be used to sort. Is it like that since before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrnli_11_11_2020_6-41-32 PM

@iamareebjamal iamareebjamal merged commit 85ac926 into fossasia:development Nov 11, 2020
@maze-runnar maze-runnar deleted the attendeeForm branch November 11, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 3: Attendee Custom Question moving to different position
2 participants