-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove intermediate step of login while registering #5504
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/jj27993wu |
Codecov Report
@@ Coverage Diff @@
## development #5504 +/- ##
===============================================
- Coverage 23.25% 23.13% -0.13%
===============================================
Files 493 493
Lines 5182 5209 +27
Branches 38 38
===============================================
Hits 1205 1205
- Misses 3972 3999 +27
Partials 5 5
Continue to review full report at Codecov.
|
app/controllers/register.js
Outdated
this.transitionToRoute('login'); | ||
} | ||
this.send('loginExistingUser', user.get('email'), password, this.inviteToken, this.event); | ||
this.transitionToRoute('/'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Shouldn't the above action be awaited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the above action be awaited?
why? I am not getting it.
Fixes #5433
Checklist
development
branch.