Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove intermediate step of login while registering #5504

Merged
merged 4 commits into from
Nov 6, 2020
Merged

fix: remove intermediate step of login while registering #5504

merged 4 commits into from
Nov 6, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5433

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/jj27993wu
✅ Preview: https://open-event-frontend-git-direct-login.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #5504 (e103d37) into development (190a3d6) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5504      +/-   ##
===============================================
- Coverage        23.25%   23.13%   -0.13%     
===============================================
  Files              493      493              
  Lines             5182     5209      +27     
  Branches            38       38              
===============================================
  Hits              1205     1205              
- Misses            3972     3999      +27     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/controllers/events/view/index.js 0.00% <0.00%> (ø)
app/controllers/events/view/scheduler.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/create.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/edit.js 0.00% <0.00%> (ø)
app/controllers/events/view/settings.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers/create.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers/edit.js 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e0cbd...028953e. Read the comment docs.

this.transitionToRoute('login');
}
this.send('loginExistingUser', user.get('email'), password, this.inviteToken, this.event);
this.transitionToRoute('/');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Shouldn't the above action be awaited?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the above action be awaited?

why? I am not getting it.

@iamareebjamal iamareebjamal merged commit 3f16789 into fossasia:development Nov 6, 2020
@mariobehling mariobehling changed the title fix: remove intermidiate step of login while registering fix: remove intermediate step of login while registering Nov 7, 2020
@maze-runnar maze-runnar deleted the direct-login branch December 13, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account Registration: Get rid of intermediate step after account registration and login new user right away
2 participants