fix: Hide currency when amount is 0

[divyamtayal]

Fixes #5442
Fixes #5453

Short description of what this resolves:

$ sign was shown even when amount was 0 so fixed this issue.

Changes proposed in this pull request:

• $ sign is not shown when amount is zero

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

BEFORE

AFTER

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/cksudvdip
✅ Preview: https://open-event-frontend-git-ticket-box-5442.eventyay.vercel.app

[divyamtayal]

@mariobehling @iamareebjamal please see the changes made and let me know to do any more changes.

[codecov]

Codecov Report

Merging #5447 into development will decrease coverage by 0.03%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #5447      +/-   ##
===============================================
- Coverage        23.23%   23.19%   -0.04%     
===============================================
  Files              493      493              
  Lines             5169     5182      +13     
  Branches            38       38              
===============================================
+ Hits              1201     1202       +1     
- Misses            3963     3975      +12     
  Partials             5        5              

Impacted Files	Coverage Δ
app/components/public/add-to-calender.ts	4.54% <0.00%> (-4.55%)	⬇️
app/services/loader.js	39.56% <0.00%> (-0.44%)	⬇️
app/components/nav-bar.js	33.33% <0.00%> (+33.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea3a5f...9ca587e. Read the comment docs.

[divyamtayal]

@mariobehling @iamareebjamal Please let me know if this is not the issue what I am thinking of.

[iamareebjamal]

Please go ahead with this logic and solve other places in this PR as well

[divyamtayal]

Fixed Sales(amount)

Fixed sales and bottom column sales

Fixed amount for orders and attendees

Fixed Discount (currency not showing)

Fixed amount, subtotal (dashboard ticket page)

Fixed amount, subtotal (public ticket page)

[divyamtayal]

@iamareebjamal You mean that like I have used if statement in different files, so there should be only one if or condition statement that should handle this globally?

[iamareebjamal]

Yes

[divyamtayal]

@iamareebjamal is this the correct way?
I modified currency-symbol file and passed one more arg to work accordingly
do let me know.

[divyamtayal]

@iamareebjamal I have added the component pls see to it

[iamareebjamal]

There is no space between currency and amount

[divyamtayal]

its there

[iamareebjamal]

Half files are using component, half are not. currency-symbol helper is duplicated in all component calls

[divyamtayal]

Half files are using component, half are not. currency-symbol helper is duplicated in all component calls

@iamareebjamal in some places I have to take care of only currency symbol where theres is no amount to be rendered, so for that I think I should not call the comp. and just do it there only?

[iamareebjamal]

Let's say you have a function which returns x^2 if x is odd and 1/x if x is even. Choose what the function and function call should look like:

1. x if y else z | f(x^2, x % 2, 1/x)
2. x if y % 2 else z | f(x^2, x, 1/x)
3. x^2 if x % 2 else 1/x | f(x)

[divyamtayal]

Let's say you have a function which returns x^2 if x is odd and 1/x if x is even. Choose what the function and function call should look like:

1. x if y else z | f(x^2, x % 2, 1/x)

2. x if y % 2 else z | f(x^2, x, 1/x)

3. x^2 if x % 2 else 1/x | f(x)

3
got it let me think of it

[divyamtayal]

@iamareebjamal

@amount={{this.model.eventDetail.paymentCurrency}}
@amount={{sub ticket.price ticket.discount}}
@amount={{mult ticket.orderStatistics.tickets.completed ticket.price}}

so now there are diff cases where sometimes there is only arg directly passing or sometimes evaluating before and then passing as a single arg doing mul or sub
so should I handle this before calculation also in comp.??

[divyamtayal]

@iamareebjamal I have some changes in the component

[iamareebjamal]

so should I handle this before calculation also in comp.??

No

[iamareebjamal]

Add tests for different cases

[divyamtayal]

ok and rest changes in file is ok?

[iamareebjamal]

Ensure there is a space between symbol and amount

[divyamtayal]

Ensure there is a space between symbol and amount

See it's there and also same in various other places

Is this right?

[divyamtayal]

@iamareebjamal I have added test, please let me know to make any changes.