feat: adding ember leaflet #5429

maze-runnar · 2020-10-30T13:14:05Z

Fixes #591

one thing is still remaining . The map is not getting correct lat and lng values. @iamareebjamal

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-10-30T13:14:11Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/j7futdjkm
✅ Preview: https://open-event-frontend-git-leaflet-map.eventyay.vercel.app

codecov · 2020-10-30T13:29:32Z

Codecov Report

Merging #5429 (b6864fc) into development (190a3d6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development    #5429      +/-   ##
===============================================
- Coverage        23.25%   23.24%   -0.01%     
===============================================
  Files              493      494       +1     
  Lines             5182     5162      -20     
  Branches            38       38              
===============================================
- Hits              1205     1200       -5     
+ Misses            3972     3957      -15     
  Partials             5        5

Impacted Files	Coverage Δ
app/components/public/event-map.js	`0.00% <0.00%> (ø)`
app/components/nav-bar.js	`0.00% <0.00%> (-33.34%)`	⬇️
app/components/tabbed-navigation.js	`33.33% <0.00%> (-20.00%)`	⬇️
app/routes/account/danger-zone.js	`0.00% <0.00%> (ø)`
app/services/loader.js	`40.00% <0.00%> (+0.43%)`	⬆️
app/components/public/add-to-calender.ts	`9.09% <0.00%> (+4.54%)`	⬆️
app/components/forms/orders/guest-order-form.js	`20.00% <0.00%> (+5.71%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e0cbd...71ad234. Read the comment docs.

iamareebjamal · 2020-10-30T15:31:04Z

Really cool. I'll check what's the issue once I'm free

iamareebjamal · 2020-10-30T22:37:27Z

The map is not getting correct lat and lng values.

I don't understand. Do you mean it is showing wrong location for a latitude and longitude? Then try switching lat and lng

iamareebjamal · 2020-10-30T22:38:17Z

app/templates/components/public/event-map.hbs

-        {{/g-map-address-marker}}
-      </GMap>
-    {{/if}}
+    <LeafletMap @lat={{this.lat}} @lng={{this.lng}} @zoom={{this.zoom}} as |layers|>


This should be shown only if event has lat lng. Otherwise, fallback to previous method

iamareebjamal · 2020-10-30T22:39:43Z

app/templates/components/public/event-map.hbs

-      </GMap>
-    {{/if}}
+    <LeafletMap @lat={{this.lat}} @lng={{this.lng}} @zoom={{this.zoom}} as |layers|>
+      <layers.tile @url="https://{s}.basemaps.cartocdn.com/light_all/{z}/{x}/{y}.png"/>


Please use a free to use basemap, this is only free for non-commercial projects

Our basemaps can be used for free in applications and visualizations for non-commercial use. For commercial purposes, you will need an Enterprise license to ensure you have the best basemaps available.

https://wiki.openstreetmap.org/wiki/Tiles#Servers

iamareebjamal · 2020-10-31T13:54:30Z

app/templates/components/public/event-map.hbs

+      {{#if (eq this.mapConfig.display 'embed') }}
+        <iframe title="Map" class="g-map" src="https://maps.google.com/maps?q={{this.event.locationName}}&t=&z=15&ie=UTF8&iwloc=&output=embed" frameborder="0" scrolling="no"></iframe>
+      {{else}}
+        <GMap @markersFitMode="live" @lat={{37.744}} @lng={{-122.4367}} @address={{this.event.locationName}} @zoom={{2}} @class="google-maps" as |context|>


Let's remove this cause our goal is to remove ember-g-map

iamareebjamal · 2020-10-31T13:55:23Z

app/components/public/event-map.js

@@ -11,7 +11,7 @@ export default class EventMap extends Component {

    @tracked
    lng = this.event.longitude;
-    
+
    @tracked
    zoom = 4;


Since this is read only?, it should not have tracked decorator

iamareebjamal · 2020-10-31T13:55:49Z

app/components/public/event-map.js

@@ -11,7 +11,7 @@ export default class EventMap extends Component {

    @tracked
    lng = this.event.longitude;


Read only properties don't need tracked

app/templates/components/public/event-map.hbs

iamareebjamal · 2020-10-31T13:57:04Z

package.json

@@ -165,6 +166,7 @@
  },
  "private": true,
  "dependencies": {
+    "ember-leaflet": "^4.1.1",


Shouldn't this be in devDependencies?

iamareebjamal · 2020-11-06T12:54:39Z

@maze-runnar What's missing here?

iamareebjamal · 2020-11-06T12:57:23Z

one thing is still remaining . The map is not getting correct lat and lng values.

I still don't understand

maze-runnar · 2020-11-06T13:33:03Z

one thing is still remaining . The map is not getting correct lat and lng values.

I still don't understand

i mean lat and lng values are not coming from backend. Map is showing correctly them on putting any lat and lng manually.

iamareebjamal · 2020-11-06T13:55:45Z

Try on this https://eventyay.com/e/45da88b7
And fix the build

maze-runnar · 2020-11-06T16:21:18Z

Try on this https://eventyay.com/e/45da88b7

showing correctly -

But it's with free ember-leaflet base map, other base-maps from https://wiki.openstreetmap.org/wiki/Tiles#Servers are showing blank screen -

iamareebjamal · 2020-11-06T22:24:36Z

Zoom level is very bad, that's why

iamareebjamal · 2020-11-06T22:25:21Z

But it's with free ember-leaflet base map

But it's with ~~free~~ paid ember-leaflet base map.

Fixed that for you. It's paid, not free

iamareebjamal · 2020-11-07T01:10:35Z

There were several things wrong and missing:

Tile server was wrong, it was supposed to be https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png. But I see the link I mentioned had a, b, c links. That's substitute for {s}
Zoom level was 4 which is country level zoom. We want 15
The way you wrote lat lng in component was wrong and crashing the test
You wrote @tracked on a computed property. @tracked is used for tracking writes and update the dependent computed properties, it does nothing on read only computed properties
You wrote @tracked in a classic component. It imports from glimmer package, thus only works on glimmer components
Most importantly, you missed the production step in Installtion guide https://miguelcobain.github.io/ember-leaflet/docs/installation. It would not have worked in production without it

iamareebjamal · 2020-11-07T01:15:01Z

You also did not follow ember install ember-leaflet which would install latest leaflet. The current installed version is 0.7 and latest version is 1.6.0

It also would have automatically installed leaflet in devDependencies

adding ember leaflet

b6864fc

vercel bot deployed to Preview October 30, 2020 13:14 View deployment

auto-label bot added the feature label Oct 30, 2020

iamareebjamal reviewed Oct 30, 2020

View reviewed changes

updating as per required

ec327cb

vercel bot deployed to Preview October 31, 2020 10:04 View deployment

iamareebjamal reviewed Oct 31, 2020

View reviewed changes

app/templates/components/public/event-map.hbs Show resolved Hide resolved

iamareebjamal reviewed Oct 31, 2020

View reviewed changes

fix

bb2d856

vercel bot deployed to Preview October 31, 2020 17:46 View deployment

finalizing pr

9a0b736

vercel bot deployed to Preview November 4, 2020 10:43 View deployment

Merge branch 'development' into leaflet-map

e3ae689

vercel bot deployed to Preview November 4, 2020 10:49 View deployment

Merge branch 'development' into leaflet-map

56b2a9b

vercel bot deployed to Preview November 6, 2020 16:21 View deployment

fix

48647d5

vercel bot deployed to Preview November 7, 2020 01:03 View deployment

fix

71ad234

vercel bot deployed to Preview November 7, 2020 01:08 View deployment

fix

9d3fb9a

vercel bot deployed to Preview November 7, 2020 01:22 View deployment

fix

57df6de

vercel bot deployed to Preview November 7, 2020 01:26 View deployment

Merge branch 'development' into leaflet-map

9359051

iamareebjamal merged commit bac8331 into fossasia:development Nov 7, 2020

vercel bot deployed to Preview November 7, 2020 01:30 View deployment

maze-runnar deleted the leaflet-map branch December 13, 2020 03:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding ember leaflet #5429

feat: adding ember leaflet #5429

maze-runnar commented Oct 30, 2020 •

edited

Loading

vercel bot commented Oct 30, 2020 •

edited

Loading

codecov bot commented Oct 30, 2020 •

edited

Loading

iamareebjamal commented Oct 30, 2020

iamareebjamal commented Oct 30, 2020

iamareebjamal Oct 30, 2020

iamareebjamal Oct 30, 2020

iamareebjamal Oct 30, 2020

maze-runnar Oct 31, 2020

iamareebjamal Oct 31, 2020

iamareebjamal Oct 31, 2020

iamareebjamal Oct 31, 2020

iamareebjamal Oct 31, 2020

iamareebjamal commented Nov 6, 2020

iamareebjamal commented Nov 6, 2020

maze-runnar commented Nov 6, 2020

iamareebjamal commented Nov 6, 2020

maze-runnar commented Nov 6, 2020

iamareebjamal commented Nov 6, 2020

iamareebjamal commented Nov 6, 2020

iamareebjamal commented Nov 7, 2020 •

edited

Loading

iamareebjamal commented Nov 7, 2020 •

edited

Loading

		@@ -11,7 +11,7 @@ export default class EventMap extends Component {

		@tracked
		lng = this.event.longitude;

feat: adding ember leaflet #5429

feat: adding ember leaflet #5429

Conversation

maze-runnar commented Oct 30, 2020 • edited Loading

Checklist

vercel bot commented Oct 30, 2020 • edited Loading

codecov bot commented Oct 30, 2020 • edited Loading

Codecov Report

iamareebjamal commented Oct 30, 2020

iamareebjamal commented Oct 30, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamareebjamal commented Nov 6, 2020

iamareebjamal commented Nov 6, 2020

maze-runnar commented Nov 6, 2020

iamareebjamal commented Nov 6, 2020

maze-runnar commented Nov 6, 2020

iamareebjamal commented Nov 6, 2020

iamareebjamal commented Nov 6, 2020

iamareebjamal commented Nov 7, 2020 • edited Loading

iamareebjamal commented Nov 7, 2020 • edited Loading

maze-runnar commented Oct 30, 2020 •

edited

Loading

vercel bot commented Oct 30, 2020 •

edited

Loading

codecov bot commented Oct 30, 2020 •

edited

Loading

iamareebjamal commented Nov 7, 2020 •

edited

Loading

iamareebjamal commented Nov 7, 2020 •

edited

Loading