Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show name and emails of speakers in session notify modal #5427

Closed
wants to merge 11 commits into from
Closed

fix: Show name and emails of speakers in session notify modal #5427

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8e42176
Show Email Address
Oct 30, 2020
615f889
Show Name and Email
Oct 30, 2020
d97279d
Code Cleanup
Oct 30, 2020
cf446c9
Added Computed Prop
Oct 31, 2020
4204a26
Merge branch 'development' into speak-notif-5309
Nov 2, 2020
c641fa1
Added Computed Prop-1
Nov 2, 2020
4c4bf22
Merge branch 'speak-notif-5309' of https://github.com/daretobediffere…
Nov 2, 2020
5eda544
Code Cleanup-1
Nov 2, 2020
2202962
Code Cleanup-2
Nov 2, 2020
82463aa
Code Cleanup-3
Nov 2, 2020
9c2dbf5
Code Cleanup-4
Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/modals/session-notify-modal.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<Input
type="text"
name="name and email"
@value={{this.speakers}}
@value={{this.speakerEmails}}
disabled />
</div>
<div class="field">
Expand Down
5 changes: 3 additions & 2 deletions app/components/modals/session-notify-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ export default class SessionNotifyModal extends ModalBase {
@tracked saving = false;
@tracked subject = '';
@tracked message = '';
@tracked speakers = null;
@tracked cc = '';
speakerEmails = '';

constructor() {
super(...arguments);
Expand Down Expand Up @@ -42,7 +43,7 @@ export default class SessionNotifyModal extends ModalBase {
}
this.mails = await mailPromise;
const session = this.store.peekRecord('session', this.sessionId, { backgroundReload: false });
this.speakers = session.speakers.map(speaker => `${speaker.name} ${speaker.email}`).join(', ');
this.speakerEmails = session.speakers.map(speaker => `${speaker.name} ${speaker.email}`).join(', ');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See how computed properties are created

}

@action
Expand Down