Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cfs speaker edit properly after cfs is closed #5387

Merged
merged 4 commits into from
Nov 7, 2020
Merged

fix: cfs speaker edit properly after cfs is closed #5387

merged 4 commits into from
Nov 7, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5341

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Oct 26, 2020
@vercel
Copy link

vercel bot commented Oct 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/1l7kr4e4p
✅ Preview: https://open-event-frontend-git-cfs-editspeaker.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #5387 (61e2693) into development (b2017b3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5387   +/-   ##
============================================
  Coverage        23.24%   23.25%           
============================================
  Files              493      493           
  Lines             5170     5169    -1     
  Branches            38       38           
============================================
  Hits              1202     1202           
+ Misses            3963     3962    -1     
  Partials             5        5           
Impacted Files Coverage Δ
app/routes/public/cfs/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2017b3...be7b409. Read the comment docs.

@iamareebjamal
Copy link
Member

@maze-runnar Does this work without changes in the server?

@iamareebjamal iamareebjamal self-requested a review November 6, 2020 21:14
@maze-runnar
Copy link
Contributor Author

@maze-runnar Does this work without changes in the server?

yes, it is working.

@iamareebjamal
Copy link
Member

Please don't comment code. Code should never be commented out, it should be deleted. When someone dies, we cremate or bury them, we don't keep them decorated in our home. So why should dead code be treated better?

@iamareebjamal iamareebjamal merged commit 29368d7 into fossasia:development Nov 7, 2020
@maze-runnar maze-runnar deleted the cfs-editspeaker branch November 8, 2020 02:30
@maze-runnar
Copy link
Contributor Author

When someone dies, we cremate or bury them, we don't keep them decorated in our home. So why should dead code be treated better?

ok 😑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speaker Edit shows error "call for speaker not issued yet" if there is no CfS
2 participants