Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change event times according to timezone change #5237

Merged
merged 2 commits into from
Oct 4, 2020
Merged

fix: Change event times according to timezone change #5237

merged 2 commits into from
Oct 4, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5188

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/anr6qp3kq
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-sessionsave.eventyay.vercel.app

@auto-label auto-label bot added the fix label Oct 4, 2020
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/components/forms/wizard/basic-details-step.js  2
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #5237 into development will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5237      +/-   ##
===============================================
+ Coverage        22.69%   22.73%   +0.04%     
===============================================
  Files              490      490              
  Lines             5199     5207       +8     
  Branches            36       36              
===============================================
+ Hits              1180     1184       +4     
- Misses            4014     4018       +4     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/forms/wizard/basic-details-step.js 21.83% <50.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9300e...0b08990. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix: Adding date/time and then changing the timezone will not change the date/time after saving event fix: Change event times according to timezone change Oct 4, 2020
@iamareebjamal iamareebjamal merged commit 1d9e239 into fossasia:development Oct 4, 2020
@maze-runnar maze-runnar deleted the sessionsave branch October 5, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 1: Adding date/time and then changing the timezone will change the date/time after saving event
3 participants