Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use UTC timezone for invoice issue dates #5204

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 30, 2020

And reload event invoice manually in route because as usual, ember-data reload true doesn't work

emberjs/data#3704

@vercel
Copy link

vercel bot commented Sep 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7x2py4b8t
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-invoice-tz.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 4
           

See the complete overview on Codacy

isSortable : true,
cellComponent : 'ui-table/cell/cell-date',
options: {
timezone: 'UTC',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Missing space after key 'timezone'.

cellComponent : 'ui-table/cell/cell-date',
options: {
timezone: 'UTC',
dateFormat: 'MMMM DD, YYYY'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Missing space after key 'dateFormat'.

isSortable : true
isSortable : true,
cellComponent : 'ui-table/cell/cell-date',
options: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Missing space after key 'options'.

@@ -18,7 +18,12 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
{
name : 'Date',
valuePath : 'issuedAt',
isSortable : true
isSortable : true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Missing space after key 'isSortable'.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #5204 into development will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5204      +/-   ##
===============================================
- Coverage        22.68%   22.63%   -0.06%     
===============================================
  Files              489      490       +1     
  Lines             5198     5201       +3     
  Branches            36       36              
===============================================
- Hits              1179     1177       -2     
- Misses            4014     4019       +5     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/account/billing/invoices/list.js 0.00% <ø> (ø)
app/routes/event-invoice/review.js 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 26.66% <0.00%> (-20.01%) ⬇️
app/components/ui-table/cell/cell-date.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9223879...f4a9447. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 3b329eb into fossasia:development Sep 30, 2020
@iamareebjamal iamareebjamal deleted the invoice-tz branch September 30, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants