-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use UTC timezone for invoice issue dates #5204
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7x2py4b8t |
Issues
======
- Added 4
See the complete overview on Codacy |
isSortable : true, | ||
cellComponent : 'ui-table/cell/cell-date', | ||
options: { | ||
timezone: 'UTC', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Missing space after key 'timezone'.
cellComponent : 'ui-table/cell/cell-date', | ||
options: { | ||
timezone: 'UTC', | ||
dateFormat: 'MMMM DD, YYYY' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Missing space after key 'dateFormat'.
isSortable : true | ||
isSortable : true, | ||
cellComponent : 'ui-table/cell/cell-date', | ||
options: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Missing space after key 'options'.
@@ -18,7 +18,12 @@ export default class extends Controller.extend(EmberTableControllerMixin) { | |||
{ | |||
name : 'Date', | |||
valuePath : 'issuedAt', | |||
isSortable : true | |||
isSortable : true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Missing space after key 'isSortable'.
Codecov Report
@@ Coverage Diff @@
## development #5204 +/- ##
===============================================
- Coverage 22.68% 22.63% -0.06%
===============================================
Files 489 490 +1
Lines 5198 5201 +3
Branches 36 36
===============================================
- Hits 1179 1177 -2
- Misses 4014 4019 +5
Partials 5 5
Continue to review full report at Codecov.
|
And reload event invoice manually in route because as usual, ember-data
reload
true doesn't workemberjs/data#3704