Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow newline in sanitized HTML #5193

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 29, 2020

Fixes #3149
Fixes #4542
Fixes #5178

Example Event with line breaks and links https://open-event-frontend-czssukq39.vercel.app/e/295ce8c5

@vercel
Copy link

vercel bot commented Sep 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/czssukq39
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-newline.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #5193 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5193   +/-   ##
============================================
  Coverage        22.66%   22.66%           
============================================
  Files              489      489           
  Lines             5189     5189           
  Branches            36       36           
============================================
  Hits              1176     1176           
  Misses            4008     4008           
  Partials             5        5           
Impacted Files Coverage Δ
app/services/sanitizer.js 81.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46367e9...968fe15. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 59c40c2 into fossasia:development Sep 29, 2020
@iamareebjamal iamareebjamal deleted the newline branch October 6, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant