Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Number of ticket calculation transpilation #5119

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 22, 2020

Fixes #5117

For some reason, babel wasn't transpiling data.tickets?.length || 0 correctly. It transpiled it to 0 statically meaning no matter what the case, number of tickets were evaluated to 0

@vercel
Copy link

vercel bot commented Sep 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2x40hdfgx
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-ticket-number.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 22, 2020
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #5119 into development will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5119   +/-   ##
============================================
  Coverage        22.80%   22.80%           
============================================
  Files              489      489           
  Lines             5169     5169           
  Branches            35       35           
============================================
  Hits              1179     1179           
  Misses            3985     3985           
  Partials             5        5           
Impacted Files Coverage Δ
app/mixins/event-wizard.js 0.98% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cad957...85bce0f. Read the comment docs.

@iamareebjamal iamareebjamal merged commit e98ab8d into fossasia:development Sep 22, 2020
@iamareebjamal iamareebjamal deleted the ticket-number branch September 22, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Save Event Error "Tickets are required" even though ticket is there
1 participant