fix: removing ticket group, some extra line and adding a popup

[maze-runnar]

Fixes #4623
Fixes #5095
@iamareebjamal , when i am clicking no in confirm modal, it is executing action, and on yes it's not. means that in this, yes is working as no, and no is working as yes. rest is working correctly.

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/jk43avp17
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-ticketgroup.eventyay.vercel.app

[maze-runnar]

[codecov]

Codecov Report

Merging #5084 into development will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development    #5084      +/-   ##
===============================================
+ Coverage        22.79%   22.88%   +0.08%     
===============================================
  Files              489      489              
  Lines             5173     5166       -7     
  Branches            35       35              
===============================================
+ Hits              1179     1182       +3     
+ Misses            3989     3979      -10     
  Partials             5        5              

Impacted Files	Coverage Δ
app/components/widgets/forms/ticket-input.js	66.66% <0.00%> (-13.34%)	⬇️
app/helpers/confirm.js	11.11% <0.00%> (-5.56%)	⬇️
app/controllers/account/billing/invoices/list.js	0.00% <0.00%> (ø)
app/routes/account/billing/invoices/list.js	60.00% <0.00%> (+7.05%)	⬆️
app/components/tabbed-navigation.js	53.33% <0.00%> (+20.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b48c7...551d337. Read the comment docs.

[mariobehling]

Thanks. For the pop up font, style and size please use the same styles as it is used for other pop ups elsewhere.

[mariobehling]

It seems the pop up functionality is inverted. Instead of yes/no please use OK/Cancel.

• The pop-up text states the following: "To sell hidden tickets you need to set up an access code under Event Dashboard > Tickets Tab > Access Code. [OK] [Cancel]"
  • If the user chooses "OK" add the tick in the tick box
  • If the user chooses "Cancel" do not add a tick in the box

[maze-runnar]

Instead of yes/no please use OK/Cancel.

@iamareebjamal how to change button text in confirm helper?

[iamareebjamal]

Make them props

[maze-runnar]

how to use them in helper

[iamareebjamal]

Currently they'll be hardcoded. You have to make them props and pass them in the component

[iamareebjamal]

See other dialogs which are using OK/Cancel

[maze-runnar]

[mariobehling]

For the pop up font, style and size please use the same styles as it is used for other pop ups elsewhere.

[mariobehling]

• Good that you took out the horizontal lines, but we also need to keep some spacing in the area where the horizontal line breaks used to be. So, yes get rid of the horizontal line breaks, but keep a bit of spacing in the area, please.
• One of the PRs recently introduced a line break below "Yes, accept payment through Stripe. Please also get rid of that line break and make it look the same as the above area of Paypal.
  

[maze-runnar]

[maze-runnar]

[niranjan94]

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/helpers/confirm.js  1
         

See the complete overview on Codacy

[mariobehling]

Looks good for me UI wise. @iamareebjamal Please check code. Thank you.

[iamareebjamal]

Can you explain please what is happening here. Looks very confusing

[maze-runnar]

this.confirm.prompt('Are You Sure?', { 'denyText': params[2], 'approveText': params[3], 'denyColor': params[4], 'approveColor': params[5], 'extra': params[0] })

the options are from service/confirm.js. In confirm-moda.js these are props (denyText, approveText...). in confirm modal helper i am using those and in component passing them.