Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change email verification message on success #5001

Merged
merged 3 commits into from
Sep 7, 2020
Merged

fix: change email verification message on success #5001

merged 3 commits into from
Sep 7, 2020

Conversation

bsanket16
Copy link
Member

Fixes #
Altering email verification message on successful verification of users #4989

Short description of what this resolves:

Showing Email Verification message after checking authentication

Changes proposed in this pull request:

  • case1 : Authenticated
    Message: Your email has been successfully verified!

  • case2: Not Authenticated
    Message: Your email has been successfully verified! Please login to continue.

@vercel
Copy link

vercel bot commented Sep 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9edtv7nrv
✅ Preview: https://open-event-frontend-git-fork-bsanket16-alter-verification-text.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 7, 2020
<p>Your email has been verified successfully!</p>
{{else}}
<p>Your email has been verified successfully! Please login to continue.</p>
{{/if}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than half of the message is duplicated, please remove it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed duplication! Please have a look now

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #5001 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5001   +/-   ##
============================================
  Coverage        22.66%   22.66%           
============================================
  Files              485      485           
  Lines             5153     5153           
  Branches            21       21           
============================================
  Hits              1168     1168           
  Misses            3981     3981           
  Partials             4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf863a...618b6c7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants