-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change email verification message on success #5001
fix: change email verification message on success #5001
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9edtv7nrv |
app/templates/verify.hbs
Outdated
<p>Your email has been verified successfully!</p> | ||
{{else}} | ||
<p>Your email has been verified successfully! Please login to continue.</p> | ||
{{/if}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More than half of the message is duplicated, please remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed duplication! Please have a look now
Codecov Report
@@ Coverage Diff @@
## development #5001 +/- ##
============================================
Coverage 22.66% 22.66%
============================================
Files 485 485
Lines 5153 5153
Branches 21 21
============================================
Hits 1168 1168
Misses 3981 3981
Partials 4 4 Continue to review full report at Codecov.
|
Fixes #
Altering email verification message on successful verification of users #4989
Short description of what this resolves:
Showing Email Verification message after checking authentication
Changes proposed in this pull request:
case1 : Authenticated
Message: Your email has been successfully verified!
case2: Not Authenticated
Message: Your email has been successfully verified! Please login to continue.