Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only show schedule and calendar on public page when published #4923

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Conversation

maze-runnar
Copy link
Contributor

Fixes #4922

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/52fcm4vb9
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-9.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #4923 into development will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4923      +/-   ##
===============================================
- Coverage        23.22%   23.16%   -0.06%     
===============================================
  Files              481      481              
  Lines             5098     5098              
  Branches            18       18              
===============================================
- Hits              1184     1181       -3     
- Misses            3910     3913       +3     
  Partials             4        4              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93c224...08e398d. Read the comment docs.

@iamareebjamal
Copy link
Member

They shouldn't be shown on /schedule page as well

@iamareebjamal iamareebjamal merged commit f59c383 into fossasia:development Sep 4, 2020
@iamareebjamal
Copy link
Member

They shouldn't be shown on /schedule page as well

@maze-runnar I commented this 3 days ago

@maze-runnar
Copy link
Contributor Author

They shouldn't be shown on /schedule page as well

@maze-runnar I commented this 3 days ago

I fixed that at that time I think this was it. Sorry if I didn't get it clearly.

@maze-runnar maze-runnar deleted the patch-9 branch September 4, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show schedule and calendar on public page once organizer published it
2 participants