Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separate required and optional attendee fields #4916

Merged
merged 2 commits into from
Aug 30, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 30, 2020

Fixes #4606

image
image

@vercel
Copy link

vercel bot commented Aug 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/l4oq0y7nk
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-fixed-fields.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #4916 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4916      +/-   ##
===============================================
- Coverage        23.17%   23.16%   -0.01%     
===============================================
  Files              481      481              
  Lines             5096     5098       +2     
  Branches            18       18              
===============================================
  Hits              1181     1181              
- Misses            3911     3913       +2     
  Partials             4        4              
Impacted Files Coverage Δ
app/components/forms/wizard/attendee-step.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1474c3...68ed014. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 9663982 into fossasia:development Aug 30, 2020
@iamareebjamal iamareebjamal deleted the fixed-fields branch August 30, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant