-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add timezone picker #4860
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/erwocd1m7 |
|
Codecov Report
@@ Coverage Diff @@
## development #4860 +/- ##
===============================================
+ Coverage 23.29% 23.35% +0.06%
===============================================
Files 480 481 +1
Lines 5086 5090 +4
Branches 17 18 +1
===============================================
+ Hits 1185 1189 +4
Misses 3897 3897
Partials 4 4
Continue to review full report at Codecov.
|
app/controllers/public/sessions.js
Outdated
queryParams = ['sort']; | ||
sort = 'starts-at'; | ||
isTrackVisible = false; | ||
|
||
timezones = timezones; | ||
currentTimezone = moment.tz.guess(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be event timezone by default, not local timezone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Session page drop down is showing event timezone by default, not local timezone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currentTimezone = moment.tz.guess();
this line is for in other condition current timezone, other than event timezone. I can initialize it with any walue of time, session page will show same event timezone by default
Fixes #4734
Short description of what this resolves:
Display timezone on public event page
Checklist
development
branch.