Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timezone picker #4860

Merged
merged 5 commits into from
Aug 25, 2020
Merged

feat: Add timezone picker #4860

merged 5 commits into from
Aug 25, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Aug 24, 2020

Fixes #4734

Short description of what this resolves:

Display timezone on public event page

Screenshot from 2020-08-24 22-26-19
Screenshot from 2020-08-24 22-26-15
Screenshot from 2020-08-24 22-25-56

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/erwocd1m7
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-3.eventyay.vercel.app

@iamareebjamal
Copy link
Member

iamareebjamal commented Aug 24, 2020

  • It should say Europe/Paris (Event) and Asia/Kolkata (Local)
  • Event timezone should be the default selected, not local timezone
  • Local timezone should be the first option in dropdown

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #4860 into development will increase coverage by 0.06%.
The diff coverage is 20.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4860      +/-   ##
===============================================
+ Coverage        23.29%   23.35%   +0.06%     
===============================================
  Files              480      481       +1     
  Lines             5086     5090       +4     
  Branches            17       18       +1     
===============================================
+ Hits              1185     1189       +4     
  Misses            3897     3897              
  Partials             4        4              
Impacted Files Coverage Δ
app/components/schedule.ts 65.85% <ø> (ø)
app/controllers/public/sessions.js 0.00% <0.00%> (ø)
app/utils/dictionary/date-time.ts 100.00% <ø> (ø)
app/components/widgets/time-zone-picker.ts 33.33% <33.33%> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9948804...e3d5cfe. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview August 24, 2020 17:51 Inactive
@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-08-24 23-20-03

queryParams = ['sort'];
sort = 'starts-at';
isTrackVisible = false;

timezones = timezones;
currentTimezone = moment.tz.guess();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be event timezone by default, not local timezone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Session page drop down is showing event timezone by default, not local timezone

Copy link
Contributor Author

@maze-runnar maze-runnar Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currentTimezone = moment.tz.guess();

this line is for in other condition current timezone, other than event timezone. I can initialize it with any walue of time, session page will show same event timezone by default

@iamareebjamal iamareebjamal changed the title Display timezone on public event session page feat: Add timezone picker Aug 24, 2020
@auto-label auto-label bot added the feature label Aug 24, 2020
@iamareebjamal iamareebjamal merged commit 49b65fb into fossasia:development Aug 25, 2020
@maze-runnar maze-runnar deleted the patch-3 branch August 25, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler: Display timezone on public event schedule
2 participants