Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check session and speaker available for side-menu #4848

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 23, 2020

Fixes #4804

@auto-label auto-label bot added the fix label Aug 23, 2020
@vercel
Copy link

vercel bot commented Aug 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ovelesx77
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-speaker-show.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #4848 into development will decrease coverage by 0.07%.
The diff coverage is 11.11%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4848      +/-   ##
===============================================
- Coverage        23.36%   23.29%   -0.08%     
===============================================
  Files              480      480              
  Lines             5075     5082       +7     
  Branches            16       16              
===============================================
- Hits              1186     1184       -2     
- Misses            3886     3895       +9     
  Partials             3        3              
Impacted Files Coverage Δ
app/components/public/side-menu.js 0.00% <0.00%> (ø)
app/routes/public/speakers.js 33.33% <50.00%> (+33.33%) ⬆️
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57fdbcc...33ccced. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Event Page/Scheduler: Speakers page of an event is not listed in the left side menu
1 participant