feat: improve speaker list page column organization #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/80oc8tzvx |
snitin315
force-pushed
the
fix/speakers-table
branch
from
966cb7f to
32b4c57
Compare
Codecov Report
@@ Coverage Diff @@
## development #4824 +/- ##
===============================================
+ Coverage 23.48% 23.53% +0.05%
===============================================
Files 481 481
Lines 5085 5085
Branches 16 16
===============================================
+ Hits 1194 1197 +3
+ Misses 3887 3884 -3
Partials 4 4
Continue to review full report at Codecov.
|
|
Make the icons into "real links" so they can be opened in the browser in a new tab (e.g. using mouse right click) |
| @@ -1,11 +1,13 @@ | |||
| <div class="ui {{if this.device.isMobile 'horizontal' 'vertical'}} compact basic buttons"> | |||
| <UiPopup @content={{t "View"}} @class="ui icon button" @click={{action this.props.actions.viewSpeaker this.record}} @position="left center"> | |||
| {{this.record}} | |||
vsasvipul0605
approved these changes
Aug 20, 2020
iamareebjamal
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Fixes #4821
Changes proposed in this pull request:
Checklist
developmentbranch.