Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show error details on deleting event #4819

Merged
merged 1 commit into from
Aug 20, 2020
Merged

fix: Show error details on deleting event #4819

merged 1 commit into from
Aug 20, 2020

Conversation

blossom2017
Copy link
Contributor

@blossom2017 blossom2017 commented Aug 19, 2020

Fixes #3508

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/hxlu65b9u
✅ Preview: https://open-event-frontend-git-fork-blossom2017-i3508.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #4819 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4819      +/-   ##
===============================================
- Coverage        23.50%   23.49%   -0.01%     
===============================================
  Files              481      481              
  Lines             5079     5081       +2     
  Branches            16       16              
===============================================
  Hits              1194     1194              
- Misses            3881     3883       +2     
  Partials             4        4              
Impacted Files Coverage Δ
app/controllers/admin/events/list.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43df1b...2f675aa. Read the comment docs.

@iamareebjamal iamareebjamal changed the title Shows Error details on deletingEvent() fix: Show error details on deleting event Aug 20, 2020
@auto-label auto-label bot added the fix label Aug 20, 2020
@iamareebjamal iamareebjamal merged commit 1763c2b into fossasia:development Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper error message should be displayed when deleting an event
2 participants