Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Standardize Logic and Admin Control to list events on index #4780

Closed
wants to merge 1 commit into from
Closed

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Aug 17, 2020

Fixes (Partly) #4697

Short description of what this resolves:

We have tried different ways to control events automatically that we want to show up on the front page. It is time to standardize a logic how events show up on the front page.

  1. Featured Events
  • This is easy. Any event that is switched to "Featured Event" by admins is listed here.
  1. Upcoming Events
  • up to 21 events should be listed here
  • admins should have the option to move any event without restrictions to the top of this line by switching events to "Promoted Events" in the event admin panel
  • promoted events should always show up on the top of "Upcoming Events"
  • other than that there are the following requirements for events to show up here (if they are not promoted). The event should have
    • location or online link and a date
    • a minimum of 8 paid tickets sold or be a paid pro-event
    • Once tickets are sold out the event should not be promoted to the front page anymore. Once the ticket sales period has ended the event should not be promoted to the front page anymore
    • an event image
  1. Call for Speakers
  • Up to 12 events should be listed here and there should be a "more link" below to show more events on the cfs page if there are more events
  • Events listed here on top of the queue should be "Pro Events"
  • Non-Pro Events can be listed here as well, if they have
    • Call for Speakers
    • a location or online link and a data
    • an event image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/mlu9od7ir
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-1.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #4780 into development will increase coverage by 0.06%.
The diff coverage is 72.72%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4780      +/-   ##
===============================================
+ Coverage        23.23%   23.30%   +0.06%     
===============================================
  Files              480      480              
  Lines             5039     5047       +8     
  Branches             9        9              
===============================================
+ Hits              1171     1176       +5     
- Misses            3867     3870       +3     
  Partials             1        1              
Impacted Files Coverage Δ
app/controllers/index.js 83.33% <72.72%> (-7.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5214898...25423c6. Read the comment docs.

@maze-runnar
Copy link
Contributor Author

this is done in another PR so closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant