Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make featured and promoted events sortable in admin #4772

Merged
merged 1 commit into from
Aug 15, 2020
Merged

fix: make featured and promoted events sortable in admin #4772

merged 1 commit into from
Aug 15, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4696

captured

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/akceagal0
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-1.eventyay.vercel.app

@maze-runnar
Copy link
Contributor Author

@iamareebjamal please review.

@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #4772 into development will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4772      +/-   ##
===============================================
+ Coverage        22.82%   22.88%   +0.05%     
===============================================
  Files              478      478              
  Lines             5060     5060              
  Branches             9        9              
===============================================
+ Hits              1155     1158       +3     
+ Misses            3904     3901       -3     
  Partials             1        1              
Impacted Files Coverage Δ
app/controllers/admin/events/list.js 0.00% <ø> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4b850...0b00e5e. Read the comment docs.

@iamareebjamal iamareebjamal changed the title making featured and promoted events sortable in admin fix: make featured and promoted events sortable in admin Aug 15, 2020
@auto-label auto-label bot added the fix label Aug 15, 2020
@iamareebjamal iamareebjamal merged commit 657983e into fossasia:development Aug 15, 2020
@maze-runnar maze-runnar deleted the patch-1 branch August 15, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin: Make Events Sortable According to Featured and Promoted Event
2 participants