Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Separate sessions and session route #4754

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 13, 2020

Fixes #4753

  • Separate sessions page and session detail page URL
  • Fix title token error on route params unavailability
  • Include required resources for sessions query

@auto-label auto-label bot added the fix label Aug 13, 2020
@vercel
Copy link

vercel bot commented Aug 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/gvkbjlsc2
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-session-list.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #4754 into development will decrease coverage by 0.10%.
The diff coverage is 20.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4754      +/-   ##
===============================================
- Coverage        22.96%   22.86%   -0.11%     
===============================================
  Files              478      478              
  Lines             5024     5051      +27     
  Branches             8        8              
===============================================
+ Hits              1154     1155       +1     
- Misses            3869     3895      +26     
  Partials             1        1              
Impacted Files Coverage Δ
app/controllers/events/view/sessions/list.js 0.00% <0.00%> (ø)
app/controllers/public/session/view.js 0.00% <ø> (ø)
app/routes/public/session/view.js 0.00% <ø> (ø)
app/routes/public/sessions/list.js 0.00% <0.00%> (ø)
app/router.js 100.00% <100.00%> (ø)
app/sentry.ts 0.00% <0.00%> (ø)
app/routes/events/view/scheduler.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eeff94...210df7f. Read the comment docs.

@iamareebjamal iamareebjamal merged commit c249e15 into fossasia:development Aug 13, 2020
@iamareebjamal iamareebjamal deleted the session-list branch August 13, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sessions public and detail page conflicting
1 participant